Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756250Ab3EQQ4i (ORCPT ); Fri, 17 May 2013 12:56:38 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:5794 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755785Ab3EQQ4g convert rfc822-to-8bit (ORCPT ); Fri, 17 May 2013 12:56:36 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 17 May 2013 09:56:10 -0700 From: Jay Agarwal To: "'Stephen Warren'" , "'thierry.reding@avionic-design.de'" CC: "'linux@arm.linux.org.uk'" , "'bhelgaas@google.com'" , "'olof@lixom.net'" , "'mturquette@linaro.org'" , "'linux-arm-kernel@lists.infradead.org'" , "'linux-tegra@vger.kernel.org'" , "'linux-kernel@vger.kernel.org'" , "'linux-pci@vger.kernel.org'" Date: Fri, 17 May 2013 22:21:38 +0530 Subject: RE: [PATCH 4/4] ARM: tegra: pcie: Enable PCIe controller on Cardhu Thread-Topic: [PATCH 4/4] ARM: tegra: pcie: Enable PCIe controller on Cardhu Thread-Index: Ac5MDiVYvwys7HTSTmeNS4cCuSA+NgFgtlKgAGM6UfA= Message-ID: References: <1368010660-31465-1-git-send-email-jagarwal@nvidia.com> <1368010660-31465-4-git-send-email-jagarwal@nvidia.com> <518A8596.7070702@wwwdotorg.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2213 Lines: 45 > > On 05/08/2013 04:57 AM, Jay Agarwal wrote: > > > - Enable PCIe controller on Cardhu > > > - Only port 2 is connected on this board > > > - Add regulators required for Tegra30 > > > - Patch is based on remotes/gitorious_thierryreding_linux/tegra/next > > > - and should be applied on top of this. > > > > > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi > > > b/arch/arm/boot/dts/tegra30-cardhu.dtsi > > > > > + pcie-controller { > > > + status = "okay"; > > > + pex-clk-supply = <&pex_hvdd_3v3_reg>; > > > + vdd-supply = <&ldo1_reg>; > > > + avdd-supply = <&ldo2_reg>; > > > + > > > + pci@3,0 { > > > + status = "okay"; > > > + }; > > > + }; > > > > So, if I apply this series, I do see the PCIe bridge and Ethernet > > device get enumerated, but I don't see the USB3 controller get > > enumerated. I believe that is a PCIe device behind the same bridge on the > same Tegra PCIe port. > > Shouldn't this device show up? > I have also reproduced this problem. I see somehow no non- > prefetchable memory is assigned to any of pcie devices. > Probably that is the reason for USB3 (pci 0000:04:00.0) not getting > enumerated since it uses only non-prefetchable memory. 1. Bus4(on which usb3 device resides) always return 0xffffffff from it's config space. which means device is not present? 2. That's why it is not assigned any resources and hence no usb3 probe happens. 3. But same bus does return valid info like vendor/device id etc from it's config space in downstream kernel and hence usb3 probe does happen. Thierry, Stephen, 4. Any idea why bus4 should return 0xffffffff values in upstream kernel? Anything missing? 5. Also, how config space of all pcie devices are mapped? I mean if I change the config space offset in dts file, then also I find correct vendor/device id etc for bus0/device0/fun0. So how this mapping happens that even after changing the config space offset in PCIe address space, it always finds correct vendor/device id. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/