Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756538Ab3EQRp5 (ORCPT ); Fri, 17 May 2013 13:45:57 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:53663 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756480Ab3EQRpz convert rfc822-to-8bit (ORCPT ); Fri, 17 May 2013 13:45:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <1368431172-6844-1-git-send-email-mhocko@suse.cz> <1368431172-6844-2-git-send-email-mhocko@suse.cz> <20130517160247.GA10023@cmpxchg.org> <20130517165712.GB12632@mtj.dyndns.org> Date: Fri, 17 May 2013 10:45:54 -0700 X-Google-Sender-Auth: r33Xvo1uaGbbrnR9aWWOWt8RIXU Message-ID: Subject: Re: [patch v3 -mm 1/3] memcg: integrate soft reclaim tighter with zone shrinking code From: Tejun Heo To: Johannes Weiner Cc: Michal Hocko , Andrew Morton , "linux-mm@kvack.org" , Cgroups , lkml , KAMEZAWA Hiroyuki , Ying Han , Hugh Dickins , Glauber Costa , Michel Lespinasse , Greg Thelen , Balbir Singh Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 29 Hello, On Fri, May 17, 2013 at 10:27 AM, Johannes Weiner wrote: >>Hmmm... if the iteration is the problem, it shouldn't be difficult to >>build list of children which should be iterated. Would that make it >>acceptable? > > You mean, a separate structure that tracks which groups are in excess of the limit? Like the current tree? :) Heh, yeah, realized that after writing it but it can be something much simpler. ie. just linked list of children with soft limit configured. > Kidding aside, yes, that would be better, and an unsorted list would probably be enough for the global case. Yeap. > To support target reclaim soft limits later on, we could maybe propagate tags upwards the cgroup tree when a group is in excess so that reclaim can be smarter about which subtrees to test for soft limits and which to skip during the soft limit pass. The no-softlimit-set-anywhere case is then only a single tag test in the root cgroup. > > But starting with the list would be simple enough, delete a bunch of code, come with the same performance improvements etc. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/