Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752631Ab3EROsT (ORCPT ); Sat, 18 May 2013 10:48:19 -0400 Received: from mga02.intel.com ([134.134.136.20]:22426 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989Ab3EROsP (ORCPT ); Sat, 18 May 2013 10:48:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,700,1363158000"; d="scan'208";a="339441370" Date: Sat, 18 May 2013 07:48:14 -0700 From: Jon Mason To: Jonghwan Choi Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Jonghwan Choi Subject: Re: [PATCH 3.9-stable] NTB: reset tx_index on link toggle Message-ID: <20130518144814.GD29066@jonmason-lab> References: <1368845237-4114-1-git-send-email-jhbird.choi@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368845237-4114-1-git-send-email-jhbird.choi@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2075 Lines: 58 On Sat, May 18, 2013 at 11:47:17AM +0900, Jonghwan Choi wrote: > From: Jon Mason > > This patch looks like it should be in the 3.9-stable tree, should we apply > it? Yes, thanks. > > ------------------ > > From: "Jon Mason " > > commit 90f9e934647e652a69396e18c779215a493271cf upstream > > If the NTB link toggles, the driver could stop receiving due to the > tx_index not being set to 0 on the transmitting size on a link-up event. > This is due to the driver expecting the incoming data to start at the > beginning of the receive buffer and not at a random place. > > Cc: # 3.9.x: ad3e2751: ntb: off by one > Cc: # 3.9.x: cc0f868d: NTB: fix pointer math > Cc: # 3.9.x: 113fc505: NTB: Handle 64bit BAR > Cc: # 3.9.x: b77b2637: NTB: Link toggle memory > Signed-off-by: Jon Mason > Signed-off-by: Jonghwan Choi > --- > drivers/ntb/ntb_transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c > index f5a424d..0828124 100644 > --- a/drivers/ntb/ntb_transport.c > +++ b/drivers/ntb/ntb_transport.c > @@ -505,6 +505,7 @@ static void ntb_transport_setup_qp_mw(struct ntb_transport *nt, > > qp->rx_pkts = 0; > qp->tx_pkts = 0; > + qp->tx_index = 0; > } > > static void ntb_free_mw(struct ntb_transport *nt, int num_mw) > @@ -819,7 +820,6 @@ static void ntb_transport_init_queue(struct ntb_transport *nt, > qp->tx_mw = qp->rx_info + 1; > qp->tx_max_frame = min(transport_mtu, tx_size); > qp->tx_max_entry = tx_size / qp->tx_max_frame; > - qp->tx_index = 0; > > if (nt->debugfs_dir) { > char debugfs_name[4]; > -- > 1.8.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/