Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034Ab3ERTgL (ORCPT ); Sat, 18 May 2013 15:36:11 -0400 Received: from cassarossa.samfundet.no ([193.35.52.29]:53892 "EHLO cassarossa.samfundet.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850Ab3ERTgJ (ORCPT ); Sat, 18 May 2013 15:36:09 -0400 Date: Sat, 18 May 2013 21:33:56 +0200 From: Hans-Christian Egtvedt To: Jiang Liu Cc: Andrew Morton , Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , Sergei Shtylyov , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Haavard Skinnemoen Subject: Re: [PATCH v7, part3 16/16] AVR32: fix building warnings caused by redifinitions of HZ Message-ID: <20130518193356.GA4953@samfundet.no> References: <1368805518-2634-1-git-send-email-jiang.liu@huawei.com> <1368805518-2634-17-git-send-email-jiang.liu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368805518-2634-17-git-send-email-jiang.liu@huawei.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2867 Lines: 61 Around Fri 17 May 2013 23:45:18 +0800 or thereabout, Jiang Liu wrote: > As suggested by David Howells , use > asm-generic/param.h and uapi/asm-generic/param.h for AVR32. > > It also fixes building warnings caused by redifinitions of HZ: > In file included from /ws/linux/kernel/linux.git/include/uapi/linux/param.h:4, > from include/linux/timex.h:63, > from include/linux/jiffies.h:8, > from include/linux/ktime.h:25, > from include/linux/timer.h:5, > from include/linux/workqueue.h:8, > from include/linux/srcu.h:34, > from include/linux/notifier.h:15, > from include/linux/memory_hotplug.h:6, > from include/linux/mmzone.h:777, > from include/linux/gfp.h:4, > from arch/avr32/mm/init.c:10: > /ws/linux/kernel/linux.git/arch/avr32/include/asm/param.h:6:1: warning: "HZ" redefined > In file included from /ws/linux/kernel/linux.git/arch/avr32/include/asm/param.h:4, > from /ws/linux/kernel/linux.git/include/uapi/linux/param.h:4, > from include/linux/timex.h:63, > from include/linux/jiffies.h:8, > from include/linux/ktime.h:25, > from include/linux/timer.h:5, > from include/linux/workqueue.h:8, > from include/linux/srcu.h:34, > from include/linux/notifier.h:15, > from include/linux/memory_hotplug.h:6, > from include/linux/mmzone.h:777, > from include/linux/gfp.h:4, > from arch/avr32/mm/init.c:10: > /ws/linux/kernel/linux.git/arch/avr32/include/uapi/asm/param.h:6:1: warning: this is the location of the previous definition > > Signed-off-by: Jiang Liu > Cc: Hans-Christian Egtvedt > Cc: Haavard Skinnemoen > Cc: linux-kernel@vger.kernel.org Thanks, I'll pull this into the linux-avr32 tree. I'm in the mountains right now, but will make a pull request early next week. Acked-by: Hans-Christian Egtvedt > --- > arch/avr32/include/asm/Kbuild | 1 + > arch/avr32/include/asm/param.h | 9 --------- > arch/avr32/include/uapi/asm/Kbuild | 1 + > arch/avr32/include/uapi/asm/param.h | 18 ------------------ > 4 files changed, 2 insertions(+), 27 deletions(-) > delete mode 100644 arch/avr32/include/asm/param.h > delete mode 100644 arch/avr32/include/uapi/asm/param.h -- HcE -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/