Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214Ab3ERVKA (ORCPT ); Sat, 18 May 2013 17:10:00 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:42230 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888Ab3ERVJ7 (ORCPT ); Sat, 18 May 2013 17:09:59 -0400 Date: Sat, 18 May 2013 23:09:48 +0200 From: Francois Romieu To: Petko Manolov Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup Message-ID: <20130518210948.GA26590@electric-eye.fr.zoreil.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 31 Petko Manolov : > From: Petko Manolov > > Moving constant and structure definitions out of rtl8150.c; What's the point ? [...] > --- > drivers/net/usb/rtl8150.c | 121 +---------------------------------- > 1 file changed, 2 insertions(+), 119 deletions(-) > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > index a491d3a..7d1897b 100644 > --- a/drivers/net/usb/rtl8150.c > +++ b/drivers/net/usb/rtl8150.c > @@ -17,132 +17,15 @@ > #include > #include > > +#include "rtl8150.h" It won't compile. You shouldn't do that. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/