Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358Ab3ERVKG (ORCPT ); Sat, 18 May 2013 17:10:06 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:42234 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257Ab3ERVKE (ORCPT ); Sat, 18 May 2013 17:10:04 -0400 Date: Sat, 18 May 2013 23:09:58 +0200 From: Francois Romieu To: Petko Manolov Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] drivers: net: usb: rtl8150: bug fixing and cleanup Message-ID: <20130518210958.GB26590@electric-eye.fr.zoreil.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 33 Petko Manolov : [...] > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > index 7d1897b..fd4bc2a 100644 > --- a/drivers/net/usb/rtl8150.c > +++ b/drivers/net/usb/rtl8150.c [...] > static void rx_fixup(unsigned long data) > { > struct rtl8150 *dev = (struct rtl8150 *)data; > struct sk_buff *skb; > int status; > > - spin_lock_irq(&dev->rx_pool_lock); > - fill_skb_pool(dev); > - spin_unlock_irq(&dev->rx_pool_lock); > if (test_bit(RX_URB_FAIL, &dev->flags)) > if (dev->rx_skb) > goto try_again; > - spin_lock_irq(&dev->rx_pool_lock); > - skb = pull_skb(dev); > - spin_unlock_irq(&dev->rx_pool_lock); > + skb = __netdev_alloc_skb_ip_align(dev->netdev, RTL8150_MTU, GFP_ATOMIC); You can use plain netdev_alloc_skb_ip_align. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/