Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753443Ab3ERVKV (ORCPT ); Sat, 18 May 2013 17:10:21 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:42240 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882Ab3ERVKQ (ORCPT ); Sat, 18 May 2013 17:10:16 -0400 Date: Sat, 18 May 2013 23:10:12 +0200 From: Francois Romieu To: Petko Manolov Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] drivers: net: usb: rtl8150: bug fixing and cleanup Message-ID: <20130518211012.GC26590@electric-eye.fr.zoreil.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 36 Petko Manolov : [...] > static int set_registers(rtl8150_t * dev, u16 indx, u16 size, void *data) > { > - return usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0), > - RTL8150_REQ_SET_REGS, RTL8150_REQT_WRITE, > - indx, 0, data, size, 500); > + int res; > + > + res = usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0), > + RTL8150_REQ_SET_REGS, RTL8150_REQT_WRITE, > + indx, 0, data, size, 500); > + if (res < 0) > + dev_dbg(&dev->udev->dev, "%s returned %d\n", __func__, res); > + return res; You may move it into a separate patch. It is completely unrelated to the ctrl_urb changes. [...] > +static int async_set_registers(rtl8150_t *dev, u16 indx, u16 size, u16 reg) > { [...] > + usb_fill_control_urb(async_urb, dev->udev, > + usb_sndctrlpipe(dev->udev, 0), (void *) &req->dr, Useless void * cast. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/