Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510Ab3ERVKr (ORCPT ); Sat, 18 May 2013 17:10:47 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:42248 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319Ab3ERVKq (ORCPT ); Sat, 18 May 2013 17:10:46 -0400 Date: Sat, 18 May 2013 23:10:41 +0200 From: Francois Romieu To: Petko Manolov Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] drivers: net: usb: rtl8150: bug fixing and cleanup Message-ID: <20130518211041.GD26590@electric-eye.fr.zoreil.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 55 Petko Manolov : [...] > @@ -681,16 +681,15 @@ static int rtl8150_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd) > } > > static const struct net_device_ops rtl8150_netdev_ops = { > - .ndo_open = rtl8150_open, > - .ndo_stop = rtl8150_close, > - .ndo_do_ioctl = rtl8150_ioctl, > - .ndo_start_xmit = rtl8150_start_xmit, > - .ndo_tx_timeout = rtl8150_tx_timeout, > - .ndo_set_rx_mode = rtl8150_set_multicast, > - .ndo_set_mac_address = rtl8150_set_mac_address, > - > - .ndo_change_mtu = eth_change_mtu, > - .ndo_validate_addr = eth_validate_addr, > + .ndo_open = rtl8150_open, > + .ndo_stop = rtl8150_close, > + .ndo_do_ioctl = rtl8150_ioctl, > + .ndo_start_xmit = rtl8150_start_xmit, > + .ndo_tx_timeout = rtl8150_tx_timeout, > + .ndo_set_rx_mode = rtl8150_set_multicast, > + .ndo_set_mac_address = rtl8150_set_mac_address, > + .ndo_change_mtu = eth_change_mtu, > + .ndo_validate_addr = eth_validate_addr, This is wrong. > @@ -771,12 +770,12 @@ static void rtl8150_disconnect(struct usb_interface *intf) > } > > static struct usb_driver rtl8150_driver = { > - .name = driver_name, > - .probe = rtl8150_probe, > - .disconnect = rtl8150_disconnect, > - .id_table = rtl8150_table, > - .suspend = rtl8150_suspend, > - .resume = rtl8150_resume, > + .name = driver_name, > + .probe = rtl8150_probe, > + .disconnect = rtl8150_disconnect, > + .id_table = rtl8150_table, > + .suspend = rtl8150_suspend, > + .resume = rtl8150_resume, > .disable_hub_initiated_lpm = 1, Sic. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/