Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991Ab3ESIg1 (ORCPT ); Sun, 19 May 2013 04:36:27 -0400 Received: from lan.nucleusys.com ([92.247.61.126]:49154 "EHLO zztop.nucleusys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753936Ab3ESIg0 (ORCPT ); Sun, 19 May 2013 04:36:26 -0400 Date: Sun, 19 May 2013 11:36:17 +0300 (EEST) From: Petko Manolov To: Francois Romieu cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] drivers: net: usb: rtl8150: bug fixing and cleanup In-Reply-To: <20130518211041.GD26590@electric-eye.fr.zoreil.com> Message-ID: References: <20130518211041.GD26590@electric-eye.fr.zoreil.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1342 Lines: 36 On Sat, 18 May 2013, Francois Romieu wrote: > Petko Manolov : > [...] > > @@ -681,16 +681,15 @@ static int rtl8150_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd) > > } > > > > static const struct net_device_ops rtl8150_netdev_ops = { > > - .ndo_open = rtl8150_open, > > - .ndo_stop = rtl8150_close, > > - .ndo_do_ioctl = rtl8150_ioctl, > > - .ndo_start_xmit = rtl8150_start_xmit, > > - .ndo_tx_timeout = rtl8150_tx_timeout, > > - .ndo_set_rx_mode = rtl8150_set_multicast, > > - .ndo_set_mac_address = rtl8150_set_mac_address, > > - > > - .ndo_change_mtu = eth_change_mtu, > > - .ndo_validate_addr = eth_validate_addr, > > + .ndo_open = rtl8150_open, > > + .ndo_stop = rtl8150_close, > > + .ndo_do_ioctl = rtl8150_ioctl, > > + .ndo_start_xmit = rtl8150_start_xmit, > > + .ndo_tx_timeout = rtl8150_tx_timeout, > > + .ndo_set_rx_mode = rtl8150_set_multicast, > > + .ndo_set_mac_address = rtl8150_set_mac_address, > > + .ndo_change_mtu = eth_change_mtu, > > + .ndo_validate_addr = eth_validate_addr, > > This is wrong. I am inclined to agree with you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/