Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753972Ab3ESImQ (ORCPT ); Sun, 19 May 2013 04:42:16 -0400 Received: from lan.nucleusys.com ([92.247.61.126]:49158 "EHLO zztop.nucleusys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753826Ab3ESImP (ORCPT ); Sun, 19 May 2013 04:42:15 -0400 Date: Sun, 19 May 2013 11:42:06 +0300 (EEST) From: Petko Manolov To: Francois Romieu cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] drivers: net: usb: rtl8150: bug fixing and cleanup In-Reply-To: <20130518210948.GA26590@electric-eye.fr.zoreil.com> Message-ID: References: <20130518210948.GA26590@electric-eye.fr.zoreil.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 37 On Sat, 18 May 2013, Francois Romieu wrote: > Petko Manolov : > > From: Petko Manolov > > > > Moving constant and structure definitions out of rtl8150.c; > > What's the point ? The general logic of having .h files applies. > [...] > > --- > > drivers/net/usb/rtl8150.c | 121 +---------------------------------- > > 1 file changed, 2 insertions(+), 119 deletions(-) > > > > diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c > > index a491d3a..7d1897b 100644 > > --- a/drivers/net/usb/rtl8150.c > > +++ b/drivers/net/usb/rtl8150.c > > @@ -17,132 +17,15 @@ > > #include > > #include > > > > +#include "rtl8150.h" > > It won't compile. You shouldn't do that. It does compile. Both inside and outside of the tree. If the proper place for rtl8150.h is somewhere in include/linux/... then it is different matter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/