Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754896Ab3ETGwU (ORCPT ); Mon, 20 May 2013 02:52:20 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:61860 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611Ab3ETGwR (ORCPT ); Mon, 20 May 2013 02:52:17 -0400 MIME-Version: 1.0 In-Reply-To: <1369031608-27347-5-git-send-email-sanjay.rawat@linaro.org> References: <1369031608-27347-1-git-send-email-sanjay.rawat@linaro.org> <1369031608-27347-5-git-send-email-sanjay.rawat@linaro.org> Date: Mon, 20 May 2013 12:22:16 +0530 Message-ID: Subject: Re: [RFC PATCH 4/6] ARM: spear: use the core cpu hotplug functions From: Viresh Kumar To: Sanjay Singh Rawat Cc: linux-arm-kernel@lists.infradead.org, linaro-dev@lists.linaro.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2187 Lines: 65 Please write spear as SPEAr. On 20 May 2013 12:03, Sanjay Singh Rawat wrote: > Generic arm cpu hotplug related functions are moved to core hotplug code, > remove the functions from the platform code. > > Signed-off-by: Sanjay Singh Rawat > --- > arch/arm/mach-spear/hotplug.c | 37 +------------------------------------ > 1 file changed, 1 insertion(+), 36 deletions(-) > > diff --git a/arch/arm/mach-spear/hotplug.c b/arch/arm/mach-spear/hotplug.c > index d97749c..988a9a6 100644 > --- a/arch/arm/mach-spear/hotplug.c > +++ b/arch/arm/mach-spear/hotplug.c > @@ -15,42 +15,7 @@ > #include > #include > #include > - > -static inline void cpu_enter_lowpower(void) > -{ > - unsigned int v; > - > - asm volatile( > - " mcr p15, 0, %1, c7, c5, 0\n" > - " dsb\n" > - /* > - * Turn off coherency > - */ > - " mrc p15, 0, %0, c1, c0, 1\n" > - " bic %0, %0, #0x20\n" > - " mcr p15, 0, %0, c1, c0, 1\n" > - " mrc p15, 0, %0, c1, c0, 0\n" > - " bic %0, %0, %2\n" > - " mcr p15, 0, %0, c1, c0, 0\n" > - : "=&r" (v) > - : "r" (0), "Ir" (CR_C) > - : "cc", "memory"); > -} > - > -static inline void cpu_leave_lowpower(void) > -{ > - unsigned int v; > - > - asm volatile("mrc p15, 0, %0, c1, c0, 0\n" > - " orr %0, %0, %1\n" > - " mcr p15, 0, %0, c1, c0, 0\n" > - " mrc p15, 0, %0, c1, c0, 1\n" > - " orr %0, %0, #0x20\n" > - " mcr p15, 0, %0, c1, c0, 1\n" > - : "=&r" (v) > - : "Ir" (CR_C) > - : "cc"); > -} I am not the best at assembly code but I can see that the two codes (here and hotplug.c) are slightly different. How can we ensure if this patch is okay? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/