Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754882Ab3ETHcl (ORCPT ); Mon, 20 May 2013 03:32:41 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:33524 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754474Ab3ETHcj (ORCPT ); Mon, 20 May 2013 03:32:39 -0400 X-AuditID: cbfee691-b7fef6d000002d62-6e-5199d195db65 Message-id: <1369035090.10521.4.camel@kjgkr> Subject: Re: [PATCH 02/15] f2fs: remove unnecessary flag set From: Jaegeuk Kim Reply-to: jaegeuk.kim@samsung.com To: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Date: Mon, 20 May 2013 16:31:30 +0900 In-reply-to: <1369020743-18520-2-git-send-email-jaegeuk.kim@samsung.com> References: <1369020743-18520-1-git-send-email-jaegeuk.kim@samsung.com> <1369020743-18520-2-git-send-email-jaegeuk.kim@samsung.com> Organization: samsung Content-type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-ywCZPx3KQ2M8Axv1uoiw" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t8zQ92pF2cGGmzba2RxaZG7xZ69J1ks Lu+aw+bA7LF7wWcmj8+b5AKYorhsUlJzMstSi/TtErgyHn9+zl7wTrDiQlMXWwPjXv4uRg4O CQETiYZX8l2MnECmmMSFe+vZuhi5OIQEljFKvPu5hRkiAVRz7As7iC0kMJ1RYtXqaIii14wS c9p2M4IkeAV0JD5PeMwEMlRYwEai84IyiMkmoC2xeb8BRKuixNv9d1lBwiJA9uX3TiAms4CH xK5jpSAVLAKqEmuWrGAFsTmBwm/W3maC6GxllOg9JgNi8wuISpxs/QS2k1mgSuLUpPusEEcq Sexu72SHuEVQ4sfkeywQ8ZfsEvf3+EPMF5D4NvkQC8TjshKbDkD9JylxcMUNlgmM4rOQTJ2F ZBJEXFOidftvdghbW2LZwtfMELatxLp176FqbCQ2XV3ACGHLS2x/O4d5ASP7KkbR1ILkguKk 9CJTveLE3OLSvHS95PzcTYyQ2Jy4g/H+AetDjFVAJ05klhJNzgfGdl5JvKGxmZGFqYmpsZG5 pRlVhJXEedVbrAOFBNITS1KzU1MLUovii0pzUosPMTJxcEo1MNZOddm3tOrwD2utSXv0vWXZ ny7MkH2fcPv7cWvJlKx9q1jnbKo/8/Ks+LZTvxb9f/KJK8j/8crV+xS9ZzfpfwvUandWcPg+ Rb0kzebHPW+26oyPV1xd+uV+X7l669uZz8pHH23OtnVdFlv+Ycl3o8nMJ9ZLSiVzV3pGT/ed W3VrGR/L4k3du8SUWIozEg21mIuKEwGvbI6M+gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFKsWRmVeSWpSXmKPExsVy+t9jQd2pF2cGGszZpmdxaZG7xZ69J1ks Lu+aw+bA7LF7wWcmj8+b5AKYohoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyV FPISc1NtlVx8AnTdMnOAdigplCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCesY Mx5/fs5e8E6w4kJTF1sD417+LkZODgkBE4mGY1/YIWwxiQv31rOB2EIC0xklVq2O7mLkArJf M0rMadvNCJLgFdCR+DzhMVMXIweHsICNROcFZRCTTUBbYvN+A4hWRYm3+++ygoRFgOzL751A TGYBD4ldx0pBKlgEVCXWLFnBCmJzAoXfrL3NBNHZyijRe0wGxOYXEJU42foJbCezQJXEqUn3 WSGOVJLY3d7JDnGLoMSPyfdYJjAKzkJSNgtJCiKuKdG6/Tc7hK0tsWzha2YI21Zi3br3UDU2 EpuuLmCEsOUltr+dw7yAkX0Vo2hqQXJBcVJ6rqFecWJucWleul5yfu4mRnD0P5PawbiyweIQ owAHoxIPb0bQzEAh1sSy4srcQ4wqQHMebVh9gVGKJS8/L1VJhDe6GyjNm5JYWZValB9fVJqT WnyIcSIjMDgmMkuJJucDU1ZeSbyhsYmZkaWRmYWRibk5LYWVxHkPtFoHCgmkJ5akZqemFqQW wRzFxMEp1cDoOzXFpPvGLJalX02tdZgUNtzP0hZOv8vf+3IbU4gmz5+HCY7JWVlWtjfmLHR/ svc2j8YJ3a+ieewCW3a1GCoKM8fnbBI/Kne1P3a6RWzzk8N90ey/497vkz4c85k1v4xHJf3T 3rWfrs7Le5zsd/fDc2+PpPOtHVGdFx1iGe7Onq8f5nc3T0CJpTgj0VCLuag4EQD+bjSGfQMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2465 Lines: 73 --=-ywCZPx3KQ2M8Axv1uoiw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry for the noise. This patch should be ignored. Thanks, 2013-05-20 (=EC=9B=94), 12:32 +0900, Jaegeuk Kim: > If an inode is recovered with its dentry, it will not invoke __f2fs_add_l= ink, > since the recovery routine checks its dentry before calling __f2fs_add_li= nk. >=20 > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/recovery.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c > index 2941987..993b601 100644 > --- a/fs/f2fs/recovery.c > +++ b/fs/f2fs/recovery.c > @@ -125,11 +125,7 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sb= i, struct list_head *head) > goto next; > =20 > entry =3D get_fsync_inode(head, ino_of_node(page)); > - if (entry) { > - if (IS_INODE(page) && is_dent_dnode(page)) > - set_inode_flag(F2FS_I(entry->inode), > - FI_INC_LINK); > - } else { > + if (!entry) { > if (IS_INODE(page) && is_dent_dnode(page)) { > err =3D recover_inode_page(sbi, page); > if (err) --=20 Jaegeuk Kim Samsung --=-ywCZPx3KQ2M8Axv1uoiw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRmdFSAAoJEEAUqH6CSFDSxRIP/iS9C/E3mYCc6XpAVd0zVrip vmFKj1NDD8MSzygRZhjYyZpcwjHAQAUX0u4d/Sp4LKmkHNw3WSSvzrkgMHOExy9C 7fJD+6sa1mbC8ZFox/JbVIcD729TLuK5Jgtx5hSM/WozRNe5S7PIO7TyBwIp7V0T D60BXSgs1RdQis9HZVOG+oacsfIyWh/NUr2+F362MFfTX+4GelVPBGvohPz9NS9f RKhoPTcauiRZRg2G7KVifAL54z+uPU2vWf1FFmhY/yljPgvC4wVO5czbWeetYzi7 EasJz1Yc+GfqkRNkok6uPb6GybixODEnSKM+hiuLkx/92x8zyaKFAq4bqUo+qE00 AXJro9mhGiTI/7E7fwQBi0ttUmWcUHw0sRjBPKTMRMBUP3TWYA3toAK4Mjknb26z RacSxczYJ+zpQn2M364fG1XXEtOAe48d3G0vYZw/N36/KSCkD/TnR5r+tQ+5W3/r HHQr5s3N+9y0lhWPgFjiK/h2TZ9hJmdj/8bIDlbiEFhILCOWT2CH5GxtViNC7d0k Q5smBFf99MBq6Bp0AKNnuke5sdJHkFnLbpPCU2LSZj0h6IoY34r7ZSaa9zN1INtS fOx6ow/jJuXnXEvz877MSYJ3GBiQ5NG0uWR3+N19e7V/S43E31FMwshaC1J5uAC5 /O4rYb/Kdt3DXIM86cQX =gfTi -----END PGP SIGNATURE----- --=-ywCZPx3KQ2M8Axv1uoiw-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/