Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691Ab3ETLrQ (ORCPT ); Mon, 20 May 2013 07:47:16 -0400 Received: from mail-ia0-f170.google.com ([209.85.210.170]:44926 "EHLO mail-ia0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755315Ab3ETLrO (ORCPT ); Mon, 20 May 2013 07:47:14 -0400 MIME-Version: 1.0 In-Reply-To: <1368765198-25550-1-git-send-email-dianders@chromium.org> References: <1368746388-20194-1-git-send-email-dianders@chromium.org> <1368765198-25550-1-git-send-email-dianders@chromium.org> Date: Mon, 20 May 2013 13:47:14 +0200 Message-ID: Subject: Re: [PATCH v3] pinctrl: samsung: fix suspend/resume functionality From: Linus Walleij To: Doug Anderson Cc: Tomasz Figa , Kukjin Kim , =?ISO-8859-1?Q?Heiko_St=FCbner?= , Olof Johansson , Stephen Warren , Thomas Abraham , Prathyush K , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 45 On Fri, May 17, 2013 at 6:33 AM, Doug Anderson wrote: > The GPIO states need to be restored after s2r and this is not currently > supported in the pinctrl driver. This patch saves the gpio states before > suspend and restores them after resume. > > Saving and restoring is done very early using syscore_ops and must > happen before pins are released from their powerdown state. > > Patch originally from Prathyush K but > rewritten by Doug Anderson . > > Signed-off-by: Prathyush K > Signed-off-by: Doug Anderson > --- > Changes in v3: > - Skip save and restore for banks with no powerdown config. > > Changes in v2: > - Now uses sycore_ops to make sure we're early enough. > - Try to handle two CON registers better. > - Should handle s3c24xx better as per Heiko. > - Simpler code; no longer tries to avoid glitching lines since > we _think_ all current SoCs should have pins in power down state > when the restore is called. > - Dropped eint patch for now; Tomasz will post his version. Looks good to me. Acked-by: Linus Walleij How are you going to merge this? Samsung tree? My pinctrl development tree? Or my fixes tree, if it's a regression for v3.10? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/