Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756344Ab3ETMge (ORCPT ); Mon, 20 May 2013 08:36:34 -0400 Received: from mail-ia0-f180.google.com ([209.85.210.180]:42385 "EHLO mail-ia0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756255Ab3ETMgc (ORCPT ); Mon, 20 May 2013 08:36:32 -0400 MIME-Version: 1.0 In-Reply-To: <1367591569-32197-10-git-send-email-lee.jones@linaro.org> References: <1367591569-32197-1-git-send-email-lee.jones@linaro.org> <1367591569-32197-10-git-send-email-lee.jones@linaro.org> Date: Mon, 20 May 2013 14:36:31 +0200 Message-ID: Subject: Re: [PATCH 09/63] dmaengine: ste_dma40: Rectify incorrect configuration validation checking From: Linus Walleij To: Lee Jones , Vinod Koul Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 21 On Fri, May 3, 2013 at 4:31 PM, Lee Jones wrote: > If we compare an event's group (dev_type / 16) with STEDMA40_DEV_DST_MEMORY > (-1), the only way we'd obtain a positive result is if we passed -16 as a > device type, which is unfeasible. Instead, it would be much more sane to > compare STEDMA40_DEV_DST_MEMORY against the raw dev_type in order to expect > the expected result. > > Signed-off-by: Lee Jones Still waiting for Vinod's ACK on this as well. Vinod? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/