Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757240Ab3ETOwX (ORCPT ); Mon, 20 May 2013 10:52:23 -0400 Received: from webmail.solarflare.com ([12.187.104.25]:42480 "EHLO webmail.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756947Ab3ETOwS (ORCPT ); Mon, 20 May 2013 10:52:18 -0400 Message-ID: <1369061535.4616.2.camel@bwh-desktop.uk.solarflarecom.com> Subject: Re: [PATCH 5/5] drivers: net: usb: rtl8150: making the code a bit better looking From: Ben Hutchings To: Petko Manolov CC: David Miller , , Date: Mon, 20 May 2013 15:52:15 +0100 In-Reply-To: References: Organization: Solarflare Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.17.20.137] X-TM-AS-Product-Ver: SMEX-10.0.0.1412-7.000.1014-19878.004 X-TM-AS-Result: No--9.855400-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2120 Lines: 63 On Sat, 2013-05-18 at 23:21 +0300, Petko Manolov wrote: [...] > @@ -681,16 +681,15 @@ static int rtl8150_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd) > } > > static const struct net_device_ops rtl8150_netdev_ops = { > - .ndo_open = rtl8150_open, > - .ndo_stop = rtl8150_close, > - .ndo_do_ioctl = rtl8150_ioctl, > - .ndo_start_xmit = rtl8150_start_xmit, > - .ndo_tx_timeout = rtl8150_tx_timeout, > - .ndo_set_rx_mode = rtl8150_set_multicast, > - .ndo_set_mac_address = rtl8150_set_mac_address, > - > - .ndo_change_mtu = eth_change_mtu, > - .ndo_validate_addr = eth_validate_addr, > + .ndo_open = rtl8150_open, > + .ndo_stop = rtl8150_close, > + .ndo_do_ioctl = rtl8150_ioctl, > + .ndo_start_xmit = rtl8150_start_xmit, > + .ndo_tx_timeout = rtl8150_tx_timeout, > + .ndo_set_rx_mode = rtl8150_set_multicast, > + .ndo_set_mac_address = rtl8150_set_mac_address, > + .ndo_change_mtu = eth_change_mtu, > + .ndo_validate_addr = eth_validate_addr, > }; > > static int rtl8150_probe(struct usb_interface *intf, [...] > @@ -771,12 +770,12 @@ static void rtl8150_disconnect(struct usb_interface *intf) > } > > static struct usb_driver rtl8150_driver = { > - .name = driver_name, > - .probe = rtl8150_probe, > - .disconnect = rtl8150_disconnect, > - .id_table = rtl8150_table, > - .suspend = rtl8150_suspend, > - .resume = rtl8150_resume, > + .name = driver_name, > + .probe = rtl8150_probe, > + .disconnect = rtl8150_disconnect, > + .id_table = rtl8150_table, > + .suspend = rtl8150_suspend, > + .resume = rtl8150_resume, > .disable_hub_initiated_lpm = 1, > }; These looked better before. Lining up initialisers in a structure definition is good style. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/