Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932109Ab3ETPyF (ORCPT ); Mon, 20 May 2013 11:54:05 -0400 Received: from cmexedge1.ext.emulex.com ([138.239.224.99]:12387 "EHLO CMEXEDGE1.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757069Ab3ETPyC (ORCPT ); Mon, 20 May 2013 11:54:02 -0400 Message-ID: <519A4716.7000001@emulex.com> Date: Mon, 20 May 2013 11:53:58 -0400 From: James Smart Reply-To: User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Ren Mingxin CC: , , , , , , , , , , , , , , Subject: Re: [PATCH 0/5] scsi: Allow fast io fail without waiting through timeout References: <1369034103-31644-1-git-send-email-renmx@cn.fujitsu.com> In-Reply-To: <1369034103-31644-1-git-send-email-renmx@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2092 Lines: 53 Ren, Based on the discussion recently held at LSF 2013, we are reworking the error recovery path to address all the issues you are mentioning. That work contradicts these patches. So for now, these should be held off. -- james s On 5/20/2013 3:14 AM, Ren Mingxin wrote: > When there is a scsi command timed-out or failed, the scsi eh > tries a thorugh recovery, which is necessary for non-redundant > systems. However, the thorugh recovery usually takes much time, > which is not acceptable for misson critical systems. To improve > this latency, if we are working on a redundant system, we should > avoid the scsi eh for its long time failing recovery, and quick > failover to another path. > > This set of patches is trying to implement above. > > NOTE: the userland tools need to eusure the environment > restriction, which will be implemented later. > > Thanks, > Ren > > Ren Mingxin (5): > scsi: rename return code FAST_IO_FAIL to FAST_IO > FC transport: Add interface to specify fast io level for timed-out cmds > SAS transport: Add interface to specify fast io level for timed-out cmds > lpfc: Allow fast timed-out io recovery > mptfusion: Allow fast timed-out io recovery > > drivers/message/fusion/mptscsih.c | 29 ++++++++- > drivers/scsi/lpfc/lpfc_scsi.c | 34 ++++++++++ > drivers/scsi/scsi_error.c | 18 ++--- > drivers/scsi/scsi_sas_internal.h | 4 - > drivers/scsi/scsi_transport_fc.c | 112 ++++++++++++++++++++++++++++++++++-- > drivers/scsi/scsi_transport_iscsi.c | 6 - > drivers/scsi/scsi_transport_sas.c | 103 ++++++++++++++++++++++++++++++++- > include/scsi/scsi.h | 2 > include/scsi/scsi_transport_fc.h | 11 +++ > include/scsi/scsi_transport_sas.h | 8 ++ > 10 files changed, 303 insertions(+), 24 deletions(-) > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/