Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757871Ab3ETSae (ORCPT ); Mon, 20 May 2013 14:30:34 -0400 Received: from mga14.intel.com ([143.182.124.37]:56583 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756334Ab3ETSac (ORCPT ); Mon, 20 May 2013 14:30:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,709,1363158000"; d="scan'208";a="337159476" Message-ID: <519A6BC7.7060902@linux.intel.com> Date: Mon, 20 May 2013 11:30:31 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Michal Hocko CC: Linus Torvalds , "H. Peter Anvin" , =?UTF-8?B?RmVybmFuZG8gTHVpcyBWw6F6cXVleiBDYW8=?= , "Rafael J. Wysocki" , the arch/x86 maintainers , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable hardware" References: <20130514160108.GA5055@dhcp22.suse.cz> <1369062192-7066-1-git-send-email-mhocko@suse.cz> <519A483F.7070400@zytor.com> <20130520164335.GA9441@dhcp22.suse.cz> <20130520182306.GA5348@dhcp22.suse.cz> In-Reply-To: <20130520182306.GA5348@dhcp22.suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1245 Lines: 32 On 05/20/2013 11:23 AM, Michal Hocko wrote: > On Mon 20-05-13 10:21:09, Linus Torvalds wrote: >> On Mon, May 20, 2013 at 9:43 AM, Michal Hocko wrote: >>> >>> The configuration has been posted in the referenced thread: >>> https://lkml.org/lkml/2013/5/14/398 >> >> Hmm. That's a regular intel i5 Sandybridge CPU. Which certainly has NX. >> >> Hmm. secondary_startup_64 isn't __initcode, is it? I think it's used >> for resuming the other CPU's too and for CPU hotplug. Yes/no? >> >> If so early_pmd_flags shouldn't be __initdata, I think. >> >> Michal, does it work if you don't do the revert, but just remove the >> __initdata instead? > > Right you are! The following patch on top of your tree fixes the > problem. Thanks a lot. I will leave the proper changelog to somebody who > is more familiar with the area but AFAIU the real problem is that > early_pmd_flags is no longer available beacause the section is gone. > I'll write it up and send a pull request to Linus. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/