Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758433Ab3ETViI (ORCPT ); Mon, 20 May 2013 17:38:08 -0400 Received: from mail-ea0-f170.google.com ([209.85.215.170]:50354 "EHLO mail-ea0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757072Ab3ETViG (ORCPT ); Mon, 20 May 2013 17:38:06 -0400 Message-ID: <519A97B8.1090503@gmail.com> Date: Mon, 20 May 2013 23:38:00 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Simon Baatz CC: Grant Likely , David Miller , Florian Fainelli , Russell King , Jason Cooper , Andrew Lunn , netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 6/7] ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes References: <1365071235-11611-1-git-send-email-florian@openwrt.org> <1367854420-8006-1-git-send-email-sebastian.hesselbarth@gmail.com> <1367854420-8006-7-git-send-email-sebastian.hesselbarth@gmail.com> <20130520212708.GA26519@schnuecks.de> In-Reply-To: <20130520212708.GA26519@schnuecks.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1118 Lines: 33 On 05/20/2013 11:27 PM, Simon Baatz wrote: > Hi Sebastian, > > On Mon, May 06, 2013 at 05:33:39PM +0200, Sebastian Hesselbarth wrote: >> This patch adds mv643xx_eth and mvmdio device tree nodes for DT enabled >> Kirkwood boards. Phy nodes are also added with reg property set on a >> per-board basis. > ... >> diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi >> index fada7e6..c01a273 100644 >> --- a/arch/arm/boot/dts/kirkwood.dtsi >> +++ b/arch/arm/boot/dts/kirkwood.dtsi >> @@ -202,5 +202,57 @@ >> clocks =<&gate_clk 4>; >> status = "disabled"; >> }; >> + >> + mdio: mdio-bus@72004 { >> + compatible = "marvell,orion-mdio"; >> + reg =<0x72004 0x84>; >> + interrupts =<11>; > > Shouldn't this be 46? Yes, mdio is using GbE0Err interrupt and that is 14 on IRQ HIGH CAUSE. I was misled by 11 on IRQ LOW CAUSE. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/