Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754487Ab3EUNLq (ORCPT ); Tue, 21 May 2013 09:11:46 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:33234 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886Ab3EUNLp (ORCPT ); Tue, 21 May 2013 09:11:45 -0400 Message-ID: <519B728F.2000905@cogentembedded.com> Date: Tue, 21 May 2013 17:11:43 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Libo Chen CC: thomas.petazzoni@free-electrons.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lizefan@huawei.com Subject: Re: [PATCH 18/19] drivers/net/ethernet/marvell: add missing platform_driver owne References: <1369104171-8824-1-git-send-email-libo.chen@huawei.com> In-Reply-To: <1369104171-8824-1-git-send-email-libo.chen@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1077 Lines: 36 Hello. On 21-05-2013 6:42, Libo Chen wrote: > set the owner of platform_driver, to ensure that the > caller of driver holds a module refernece > Signed-off-by: Libo Chen > --- > drivers/net/ethernet/marvell/mvneta.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index c966785..be35a3e 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -2820,6 +2820,7 @@ static struct platform_driver mvneta_driver = { > .remove = mvneta_remove, > .driver = { > .name = MVNETA_DRIVER_NAME, > + .owner = THIS_MODULE, Indent this = with space or indent all ='s with tabs. > .of_match_table = mvneta_match, > }, > }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/