Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752993Ab3EUTrV (ORCPT ); Tue, 21 May 2013 15:47:21 -0400 Received: from dcvr.yhbt.net ([64.71.152.64]:55241 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910Ab3EUTrU (ORCPT ); Tue, 21 May 2013 15:47:20 -0400 Date: Tue, 21 May 2013 19:47:19 +0000 From: Eric Wong To: Zach Brown Cc: "Martin K. Petersen" , Trond Myklebust , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [RFC v0 1/4] vfs: add copy_range syscall and vfs entry point Message-ID: <20130521194719.GA2957@dcvr.yhbt.net> References: <1368566126-17610-1-git-send-email-zab@redhat.com> <1368566126-17610-2-git-send-email-zab@redhat.com> <20130515194405.GA28720@dcvr.yhbt.net> <20130515200307.GD318@lenny.home.zabbo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130515200307.GD318@lenny.home.zabbo.net> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 848 Lines: 20 Zach Brown wrote: > On Wed, May 15, 2013 at 07:44:05PM +0000, Eric Wong wrote: > > Why introduce a new syscall instead of extending sys_splice? > > Personally, I think it's ugly to have different operations use the same > syscall just because their arguments match. Fair enough. I think adding a (currently unused) flags parameter would make sense for future-proofing. If this were extended to sockets/pipes, peek/nonblock/waitall flags may be added. Basically, something like splice/tee, but without needing to create/manage a pipe in userspace or needing extra syscalls/looping. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/