Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751214Ab3EVEOr (ORCPT ); Wed, 22 May 2013 00:14:47 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:34200 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750809Ab3EVEOp (ORCPT ); Wed, 22 May 2013 00:14:45 -0400 X-IronPort-AV: E=Sophos;i="4.87,719,1363104000"; d="scan'208";a="7330321" Message-ID: <519C45A3.3000005@cn.fujitsu.com> Date: Wed, 22 May 2013 12:12:19 +0800 From: Gu Zheng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Jiang Liu CC: Bjorn Helgaas , Yinghai Lu , Jiang Liu , "Rafael J . Wysocki" , Greg Kroah-Hartman , Toshi Kani , Myron Stowe , Yijing Wang , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Doug Thompson , linux-edac@vger.kernel.org Subject: Re: [RFC PATCH v2, part 2 14/18] PCI, EDAC: use hotplug-safe PCI bus iterators to walk PCI buses References: <1368550322-1045-1-git-send-email-jiang.liu@huawei.com> <1368550322-1045-14-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1368550322-1045-14-git-send-email-jiang.liu@huawei.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/05/22 12:13:18, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/05/22 12:13:22, Serialize complete at 2013/05/22 12:13:22 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1187 Lines: 37 On 05/15/2013 12:51 AM, Jiang Liu wrote: > Enhance EDAC drviers to use hotplug-safe iterators to walk PCI buses. > > Signed-off-by: Jiang Liu > Cc: Mauro Carvalho Chehab > Cc: Doug Thompson > Cc: linux-edac@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/edac/i7core_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c > index 0ec3e95..39d5823 100644 > --- a/drivers/edac/i7core_edac.c > +++ b/drivers/edac/i7core_edac.c > @@ -1296,7 +1296,7 @@ static unsigned i7core_pci_lastbus(void) > int last_bus = 0, bus; > struct pci_bus *b = NULL; > > - while ((b = pci_find_next_bus(b)) != NULL) { > + for_each_pci_root_bus(b) missing the "{": + for_each_pci_root_bus(b) { > bus = b->number; > edac_dbg(0, "Found bus %d\n", bus); > if (bus > last_bus) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/