Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730Ab3EVEeI (ORCPT ); Wed, 22 May 2013 00:34:08 -0400 Received: from mail-ve0-f173.google.com ([209.85.128.173]:59631 "EHLO mail-ve0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484Ab3EVEeG (ORCPT ); Wed, 22 May 2013 00:34:06 -0400 MIME-Version: 1.0 In-Reply-To: References: <519AF05E.1050808@huawei.com> Date: Wed, 22 May 2013 12:34:05 +0800 Message-ID: Subject: Re: [ANNOUNCE] ktap 0.1 released From: Ming Lei To: "zhangwei(Jovi)" Cc: "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 52 On Wed, May 22, 2013 at 12:19 PM, Ming Lei wrote: > On Wed, May 22, 2013 at 12:15 PM, Ming Lei wrote: >> On Tue, May 21, 2013 at 11:56 AM, zhangwei(Jovi) >> >> Nice job, I have run it on ARM already with only one line change. >> >> But looks 'Control-C' can't stop the tracing or need some time to complete it, >> see below: > > Sometimes, it doesn't work: > > $ sudo ./ktap ./scripts/kretprobe.kp > ...... > vfs_read! (execname sshd); retval:38 > ^Cvfs_read! (execname sshd); retval:38 > > probe ending > vfs_read! (execname sshd); retval:48 > vfs_read! (execname sshd); retval:2 > ^C > ^C^C^C > ^C^C^C^C^C^C^C > > ^C^C^C^C^C^C This one can be fixed by below patch, but can't work on the last one. diff --git a/vm.c b/vm.c index c5f5733..a24a389 100644 --- a/vm.c +++ b/vm.c @@ -1060,7 +1060,7 @@ ktap_State *kp_newthread(ktap_State *mainthread) void kp_user_complete(ktap_State *ks) { - if (!ks || !G(ks)->user_completion) + if (!ks || !G(ks) || !G(ks)->user_completion) return; complete(G(ks)->user_completion); Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/