Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093Ab3EVFAt (ORCPT ); Wed, 22 May 2013 01:00:49 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:43504 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335Ab3EVFAs (ORCPT ); Wed, 22 May 2013 01:00:48 -0400 Message-ID: <519C507C.50708@huawei.com> Date: Wed, 22 May 2013 12:58:36 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Libo Chen CC: , , , Andrew Morton , , , Libo Chen , , , Subject: Re: [PATCH] bestcomm: no need to free when kzalloc fail References: <1367743104-3448-1-git-send-email-libo.chen@huawei.com> <519C4E4D.1060101@huawei.com> In-Reply-To: <519C4E4D.1060101@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.68.215] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 50 On 2013/5/22 12:49, Libo Chen wrote: > > ping... > > On 2013/5/5 16:38, chenlibo.3@gmail.com wrote: >> From: Libo Chen >> >> There is no need to free bcom_eng if kzalloc fail >> kfree(NULL) is fine. We gain nothing from this patch, and it even adds one more line to the code, so just drop thi patch. >> Signed-off-by: Libo Chen >> --- >> drivers/dma/bestcomm/bestcomm.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/dma/bestcomm/bestcomm.c b/drivers/dma/bestcomm/bestcomm.c >> index a8c2e29..300ee2d 100644 >> --- a/drivers/dma/bestcomm/bestcomm.c >> +++ b/drivers/dma/bestcomm/bestcomm.c >> @@ -400,7 +400,7 @@ static int mpc52xx_bcom_probe(struct platform_device *op) >> printk(KERN_ERR DRIVER_NAME ": " >> "Can't allocate state structure\n"); >> rv = -ENOMEM; >> - goto error_sramclean; >> + goto error_kzalloc; >> } >> >> /* Save the node */ >> @@ -449,6 +449,7 @@ error_release: >> release_mem_region(res_bcom.start, sizeof(struct mpc52xx_sdma)); >> error_sramclean: >> kfree(bcom_eng); >> +error_kzalloc: >> bcom_sram_cleanup(); >> error_ofput: >> of_node_put(op->dev.of_node); >> > > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/