Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755854Ab3EVKF2 (ORCPT ); Wed, 22 May 2013 06:05:28 -0400 Received: from mail1.windriver.com ([147.11.146.13]:62744 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755017Ab3EVKFZ (ORCPT ); Wed, 22 May 2013 06:05:25 -0400 Message-ID: <519C9822.9040909@windriver.com> Date: Wed, 22 May 2013 18:04:18 +0800 From: "tiejun.chen" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Sebastian Hesselbarth CC: Andrew Lunn , Jason Cooper , , Lennert Buytenhek , , , David Miller , Subject: Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes References: <1367854420-8006-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369154510-4927-7-git-send-email-sebastian.hesselbarth@gmail.com> <20130521174849.GL26249@lunn.ch> <519C9333.20609@gmail.com> In-Reply-To: <519C9333.20609@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.162.227] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1942 Lines: 45 On 05/22/2013 05:43 PM, Sebastian Hesselbarth wrote: > On 05/21/2013 07:48 PM, Andrew Lunn wrote: >> On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: >>> This patch adds orion-eth and mvmdio device tree nodes for DT enabled >>> Dove boards. As there is only one ethernet controller on Dove, a default >>> phy node is also added with a note to set its reg property on a per-board >>> basis. >>> >>> Signed-off-by: Sebastian Hesselbarth >>> --- > ... >>> + ethernet-port@0 { >>> + device_type = "network"; >>> + compatible = "marvell,orion-eth-port"; >>> + reg =<0>; >>> + interrupts =<29>; >>> + /* overwrite MAC address in bootloader */ >>> + local-mac-address = [00 00 00 00 00 00]; >> >> Hi Sebastian >> >> Its probably a good idea to set the local administration bit in this >> MAC address. i.e. first byte is 02. > > Andrew, > > we just need an invalid address here to trigger the default behavior of > the driver and load the MAC address from its register. As PPC binding > documentation also has all zero, I just took it. The truth is in PPC case, often we set the real mac address with some variables like 'eth[x]addr' in u-boot prompt, then u-boot will parse that value to fill the dtb. At last the associated driver can get the actual mac address from the dtb. And especially for those older u-boot version, even you have to reset the 'local-mac-address' property in dts directly with the real mac address before generate the dtb since the older u-boot have no this ability to fill dtb again before pass the kernel. Tiejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/