From: ebiederm@xmission.com (Eric W. Biederman)
To: Stanislav Kinsbursky <skinsbursky@parallels.com>
Cc: viro@zeniv.linux.org.uk, serge.hallyn@canonical.com, jlayton@redhat.com,
        lucas.demarchi@profusion.mobi, rusty@rustcorp.com.au,
        linux-kernel@vger.kernel.org, oleg@redhat.com, bfields@fieldses.org,
        bharrosh@panasas.com, linux-fsdevel@vger.kernel.org,
        akpm@linux-foundation.org, devel@openvz.org
References: <20130522072840.27720.85023.stgit@localhost.localdomain>
Date: Wed, 22 May 2013 10:33:52 -0700
In-Reply-To: <20130522072840.27720.85023.stgit@localhost.localdomain>
	(Stanislav Kinsbursky's message of "Wed, 22 May 2013 11:29:18 +0400")
Message-ID: <878v36ex6n.fsf@xmission.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [RFC PATCH] fs: call_usermodehelper_root helper introduced
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1606
Lines: 36

Stanislav Kinsbursky <skinsbursky@parallels.com> writes:

> Usermode helper executes all binaries in global "init" root context. This
> doesn't allow to call a binary from other root context (for example in a
> container).
> Currently, both containerized NFS client and NFS server requires an ability to
> execute a binary in a container's root context. Root swap can be done in
> "init" callback, passed by UMH caller.
> But since we have 2 callers already (and more of them are expected to appear
> in future) and because set_fs_root() in not exported, it looks reasonable to
> add one more generic UMH helper to generic fs code.
> Root path reference must be hold by the caller, since it will be put on UMH
> thread exit.

Awesome.  With this patch as an uprivilieged user I get to pick which
binary the kernel will execute.  At least if nfs and nfsd ever runs in a
user namespace (something that looks like only matter of time).

I think this is a seriously bad idea.

Why can't we do this in userspace with setns as we do with the core dump
helper?

I am missing a lot of context here and capturing the context of a
process at time time we mount the filesystem and reconstituing it in
call user mode helper seems like something we could do.

This patch as it stands looks like it would compete for the honor of the
easiest kernel feature to exploit.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/