Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757452Ab3EVV0q (ORCPT ); Wed, 22 May 2013 17:26:46 -0400 Received: from longford.logfs.org ([213.229.74.203]:59235 "EHLO longford.logfs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754444Ab3EVV0p (ORCPT ); Wed, 22 May 2013 17:26:45 -0400 Date: Wed, 22 May 2013 15:58:24 -0400 From: =?utf-8?B?SsO2cm4=?= Engel To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Jens Axboe , Borislav Petkov , Takashi Iwai Subject: Re: [PATCH 01/14] do_mounts: constify name_to_dev_t parameter Message-ID: <20130522195822.GD7399@logfs.org> References: <1368132193-25817-1-git-send-email-joern@logfs.org> <1368132193-25817-2-git-send-email-joern@logfs.org> <20130522134812.40924cb34eaea1588b756a14@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130522134812.40924cb34eaea1588b756a14@linux-foundation.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 46 On Wed, 22 May 2013 13:48:12 -0700, Andrew Morton wrote: > On Thu, 9 May 2013 16:42:57 -0400 Joern Engel wrote: > > > --- a/include/linux/mount.h > > +++ b/include/linux/mount.h > > @@ -74,6 +74,6 @@ extern struct vfsmount *vfs_kern_mount(struct file_system_type *type, > > extern void mnt_set_expiry(struct vfsmount *mnt, struct list_head *expiry_list); > > extern void mark_mounts_for_expiry(struct list_head *mounts); > > > > -extern dev_t name_to_dev_t(char *name); > > +extern dev_t name_to_dev_t(const char *name); > > > > #endif /* _LINUX_MOUNT_H */ > > diff --git a/init/do_mounts.c b/init/do_mounts.c > > index 1d1b634..da96f85 100644 > > --- a/init/do_mounts.c > > +++ b/init/do_mounts.c > > @@ -202,7 +202,7 @@ done: > > * bangs. > > */ > > > > -dev_t name_to_dev_t(char *name) > > +dev_t name_to_dev_t(const char *name) > > { > > char s[32]; > > char *p; > > A changelog would be nice. There are 1.1 billion places in the kernel > where we could make such a change - why was this one made? I happened to hit this, got a compiler warning and decided that the proper fix was the patch above. The alternative would have been to cast away the const in users of name_to_dev_t(). I can add some comment, sure. Jörn -- It is better to die of hunger having lived without grief and fear, than to live with a troubled spirit amid abundance. -- Epictetus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/