Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476Ab3EVV2H (ORCPT ); Wed, 22 May 2013 17:28:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59150 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756946Ab3EVV2E (ORCPT ); Wed, 22 May 2013 17:28:04 -0400 Date: Wed, 22 May 2013 23:27:58 +0200 (CEST) From: Jiri Kosina To: Vincent Palatin Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Stern , Olof Johansson Subject: Re: [PATCH] HID: usbhid: ignore Jabra speakerphones HID interface In-Reply-To: <1369257474-26389-1-git-send-email-vpalatin@chromium.org> Message-ID: References: <1369257474-26389-1-git-send-email-vpalatin@chromium.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2289 Lines: 59 On Wed, 22 May 2013, Vincent Palatin wrote: > Add a quirk to ignore Jabra speakerphone 410 and 510 devices HID > interface. > On those devices, the USB audio interface is working nicely, > but the HID interface is not working with the kernel usbhid driver, > and it requires a specific userspace program. > We could unbind it from userspace but just attaching the usbhid driver has > sometimes nasty effects: > either confusing the device state machine or triggering a storm of volume key > events making eventual sound UI blinking like crazy. > > Signed-off-by: Vincent Palatin > --- > drivers/hid/hid-ids.h | 4 ++++ > drivers/hid/usbhid/hid-quirks.c | 3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h > index 38535c9..533815b 100644 > --- a/drivers/hid/hid-ids.h > +++ b/drivers/hid/hid-ids.h > @@ -447,6 +447,10 @@ > #define USB_VENDOR_ID_IRTOUCHSYSTEMS 0x6615 > #define USB_DEVICE_ID_IRTOUCH_INFRARED_USB 0x0070 > > +#define USB_VENDOR_ID_JABRA 0x0b0e > +#define USB_DEVICE_ID_JABRA_SPEAK_410 0x0412 > +#define USB_DEVICE_ID_JABRA_SPEAK_510 0x0420 > + > #define USB_VENDOR_ID_JESS 0x0c45 > #define USB_DEVICE_ID_JESS_YUREX 0x1010 > > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c > index 19b8360..d8c9aaf 100644 > --- a/drivers/hid/usbhid/hid-quirks.c > +++ b/drivers/hid/usbhid/hid-quirks.c > @@ -109,6 +109,9 @@ static const struct hid_blacklist { > { USB_VENDOR_ID_SIGMA_MICRO, USB_DEVICE_ID_SIGMA_MICRO_KEYBOARD, HID_QUIRK_NO_INIT_REPORTS }, > { USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_MOUSEPEN_I608X, HID_QUIRK_MULTI_INPUT }, > { USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M610X, HID_QUIRK_MULTI_INPUT }, > + > + { USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_410, HID_QUIRK_IGNORE }, > + { USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_510, HID_QUIRK_IGNORE }, > { 0, 0 } > }; Please do this in hid_ignore_list[] in drivers/hid/hid-core.c instead. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/