Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757278Ab3EVV4r (ORCPT ); Wed, 22 May 2013 17:56:47 -0400 Received: from toccata.ens-lyon.fr ([140.77.166.68]:55177 "EHLO toccata.ens-lyon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756038Ab3EVV4p (ORCPT ); Wed, 22 May 2013 17:56:45 -0400 X-Greylist: delayed 451 seconds by postgrey-1.27 at vger.kernel.org; Wed, 22 May 2013 17:56:45 EDT Date: Wed, 22 May 2013 23:49:07 +0200 From: Samuel Thibault To: Emil Goode Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, gregkh@linuxfoundation.org, ben@decadent.org.uk, speakup@braille.uwo.ca, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] staging: speakup: fix warnings by adding __user annotations Message-ID: <20130522214907.GY6142@type.youpi.perso.aquilenet.fr> Mail-Followup-To: Samuel Thibault , Emil Goode , w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, gregkh@linuxfoundation.org, ben@decadent.org.uk, speakup@braille.uwo.ca, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <1369248789-25957-1-git-send-email-emilgoode@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1369248789-25957-1-git-send-email-emilgoode@gmail.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2923 Lines: 60 Emil Goode, le Wed 22 May 2013 20:53:09 +0200, a ?crit : > This patch fixes the following sparse warnings by adding > __user annotations. > > drivers/staging/speakup/speakup_soft.c:248:34: warning: > incorrect type in argument 1 (different address spaces) > drivers/staging/speakup/speakup_soft.c:248:34: > expected void [noderef] *dst > drivers/staging/speakup/speakup_soft.c:248:34: > got char *[assigned] cp > drivers/staging/speakup/speakup_soft.c:272:40: warning: > incorrect type in argument 1 (different address spaces) > drivers/staging/speakup/speakup_soft.c:272:40: > expected char const [noderef] *s > drivers/staging/speakup/speakup_soft.c:272:40: > got char const *buf > drivers/staging/speakup/speakup_soft.c:306:17: warning: > incorrect type in initializer (incompatible argument 2 > (different address spaces)) > drivers/staging/speakup/speakup_soft.c:306:17: > expected long ( *read )( ... ) > drivers/staging/speakup/speakup_soft.c:306:17: > got long ( static [toplevel] * )( ... ) > drivers/staging/speakup/speakup_soft.c:307:18: warning: > incorrect type in initializer (incompatible argument 2 > (different address spaces)) > drivers/staging/speakup/speakup_soft.c:307:18: > expected long ( *write )( ... ) > drivers/staging/speakup/speakup_soft.c:307:18: > got long ( static [toplevel] * )( ... ) > > drivers/staging/speakup/devsynth.c:29:41: warning: > incorrect type in argument 2 (different address spaces) > drivers/staging/speakup/devsynth.c:29:41: > expected void const [noderef] *from > drivers/staging/speakup/devsynth.c:29:41: got char const *ptr > drivers/staging/speakup/devsynth.c:62:17: warning: > incorrect type in initializer (incompatible argument 2 > (different address spaces)) > drivers/staging/speakup/devsynth.c:62:17: > expected long ( *read )( ... ) > drivers/staging/speakup/devsynth.c:62:17: > got long ( static [toplevel] * )( ... ) > drivers/staging/speakup/devsynth.c:63:18: warning: > incorrect type in initializer (incompatible argument 2 > (different address spaces)) > drivers/staging/speakup/devsynth.c:63:18: > expected long ( *write )( ... ) > drivers/staging/speakup/devsynth.c:63:18: > got long ( static [toplevel] * )( ... ) > > Signed-off-by: Emil Goode Acked-by: Samuel Thibault -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/