Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757623Ab3EVWM6 (ORCPT ); Wed, 22 May 2013 18:12:58 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:47054 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757538Ab3EVWM4 (ORCPT ); Wed, 22 May 2013 18:12:56 -0400 MIME-Version: 1.0 In-Reply-To: <20130522205704.GB12923@phenom.dumpdata.com> References: <1365692161-13735-1-git-send-email-dgdegra@tycho.nsa.gov> <20130522191551.GB10617@phenom.dumpdata.com> <20130522205704.GB12923@phenom.dumpdata.com> From: Kent Yoder Date: Wed, 22 May 2013 17:12:24 -0500 Message-ID: Subject: Re: [tpmdd-devel] [PATCH v2] drivers/tpm: add xen tpmfront interface To: Konrad Rzeszutek Wilk Cc: leosilva@linux.vnet.ibm.com, adlai@linux.vnet.ibm.com, Daniel De Graaf , "linux-kernel@vger.kernel.org" , TPM Device Driver List , Ian.Campbell@citrix.com, Jan Beulich , xen-devel@lists.xen.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 37 On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk wrote: > On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote: >> >> + notify_remote_via_evtchn(priv->evtchn); >> >> + >> >> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6))); >> > >> > Um, + 6? Why? Is there an #define for that magic constant? >> > Should this value be read before you do the wait_for_tpm_stat stuff? >> >> This is hardcoded to 6 even in tpm.c. Time for a #define... >> >> > Otherwise it looks OK to me. Should this go through me or Kent? >> > And if so, is Kent waiting for my feedback? >> >> My comments were minor -- I was expecting feedback on your earlier >> comments before merging. I think this should go through the tpmdd >> maintainer if its going to live in drivers/char/tpm though. > > That is you I thought? > > konrad@phenom:~/mm$ scripts/get_maintainer.pl -f drivers/char/tpm > Kent Yoder (maintainer:TPM DEVICE DRIVER) > Rajiv Andrade (maintainer:TPM DEVICE DRIVER) > Marcel Selhorst (maintainer:TPM DEVICE DRIVER) > Sirrix AG (maintainer:TPM DEVICE DRIVER) > tpmdd-devel@lists.sourceforge.net (moderated list:TPM DEVICE DRIVER) > linux-kernel@vger.kernel.org (open list) That was me until today. :-) But I didn't see the response your comments yet. Kent -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/