Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757879Ab3EVWg7 (ORCPT ); Wed, 22 May 2013 18:36:59 -0400 Received: from ch1ehsobe001.messaging.microsoft.com ([216.32.181.181]:4219 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756990Ab3EVWg6 (ORCPT ); Wed, 22 May 2013 18:36:58 -0400 X-Forefront-Antispam-Report: CIP:132.245.2.69;KIP:(null);UIP:(null);IPV:NLI;H:BN1PRD0712HT004.namprd07.prod.outlook.com;RD:none;EFVD:NLI X-SpamScore: -4 X-BigFish: PS-4(zzbb2dI98dI9371I1432Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzz17326ah8275bh8275dhz2dh2a8h668h839h947hd25he5bhf0ah1288h12a5h12a9h12bdh137ah13b6h1441h14ddh1504h1537h153bh162dh1631h1758h1765h18e1h190ch1946h19b4h19c3h19ceh1ad9h1b0ah1d0ch1d2eh1d3fh1155h) Message-ID: <519D4883.9050905@caviumnetworks.com> Date: Wed, 22 May 2013 15:36:51 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Aaro Koskinen CC: David Daney , , , Linus Torvalds , , David Daney , Thomas Gleixner , Jonas Gorski Subject: Re: [PATCH] MIPS: Enable interrupts before WAIT instruction. References: <1367527692-25809-1-git-send-email-ddaney.cavm@gmail.com> <20130522223225.GH31836@blackmetal.musicnaut.iki.fi> In-Reply-To: <20130522223225.GH31836@blackmetal.musicnaut.iki.fi> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.195] X-OriginatorOrg: caviumnetworks.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1529 Lines: 50 On 05/22/2013 03:32 PM, Aaro Koskinen wrote: > Hi, > > On Thu, May 02, 2013 at 01:48:12PM -0700, David Daney wrote: >> From: David Daney >> >> As noted by Thomas Gleixner: >> >> commit cdbedc61c8 (mips: Use generic idle loop) broke MIPS as I did >> not realize that MIPS wants to invoke the wait instructions with >> interrupts enabled. >> >> Instead of enabling interrupts in arch_cpu_idle() as Thomas' initial >> patch does, we follow Linus' suggestion of doing it in the assembly >> code to prevent the compiler from rearranging things. >> >> Signed-off-by: David Daney >> Reported-by: EunBong Song >> Cc: Thomas Gleixner >> Cc: Jonas Gorski >> --- >> >> This is only very lightly tested, we need more testing before >> declaring it the definitive fix. > > I wonder what is the status of this patch? Or is there some alternative > fix? > > I have Octeon+ board that hangs during 3.10-rc2 boot in spawn_ksoftirqd() > without this. Also, this patch does not apply cleanly to 3.10-rc2 > anymore... > > A. > Ralf has an alternate fix here: http://git.linux-mips.org/pub/scm/ralf/upstream-linus.git If all goes well, it will be merged soon. David Daney -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/