MIME-Version: 1.0
In-Reply-To: <1369266331.2670.40.camel@bwh-desktop.uk.level5networks.com>
References: <1368498506-25857-1-git-send-email-yinghai@kernel.org>
	<1368498506-25857-7-git-send-email-yinghai@kernel.org>
	<51925FB0.4080504@intel.com>
	<CAE9FiQXYQEAZ=0sG6+2OdffBqfLS9MpoN1xviRR9aDbxPxcKxQ@mail.gmail.com>
	<5192946F.1050700@intel.com>
	<CAE9FiQVGGHB_amKw0-DfDifpTnRGPbxA+q3WY5F-O3x-sx386A@mail.gmail.com>
	<5192AEF4.1070905@intel.com>
	<519BE778.9040800@redhat.com>
	<20130521214912.GA21713@redhat.com>
	<519BEEA4.2030804@gmail.com>
	<20130521221117.GB803@redhat.com>
	<519BF594.1020607@gmail.com>
	<CAJZOPZKsp2_Fr3xY0NZfz5QDLn-=2fn+kL0w55EihuUgDZWEiw@mail.gmail.com>
	<1369266331.2670.40.camel@bwh-desktop.uk.level5networks.com>
Date: Thu, 23 May 2013 09:32:43 +0300
Message-ID: <CAJZOPZK-xYiY__iijF5jhPhqKK81T5QVd5DcGrcxLNAe97j5LQ@mail.gmail.com>
Subject: Re: [PATCH 6/7] PCI: Make sure VF's driver get attached after PF's
From: Or Gerlitz <or.gerlitz@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
        "Michael S. Tsirkin" <mst@redhat.com>, Don Dutile <ddutile@redhat.com>,
        Alexander Duyck <alexander.h.duyck@intel.com>,
        Yinghai Lu <yinghai@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
        Gu Zheng <guz.fnst@cn.fujitsu.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        NetDev <netdev@vger.kernel.org>,
        Jack Morgenstein <jackm@dev.mellanox.co.il>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1056
Lines: 24

On Thu, May 23, 2013 at 2:45 AM, Ben Hutchings
<bhutchings@solarflare.com> wrote:
> On Wed, 2013-05-22 at 23:16 +0300, Or Gerlitz wrote:
> [...]
>> all in all, we will look into returning  -EPROBE_DEFER from the VF
>> when they identify the problematic situation -- so for how much time
>> this is deferred? or if this isn't time based what the logical
>> condition which once met the VF probe is attempted again?
>
> My reading is that it will be retried as soon as the PF probe returns.
> But I've never tried using this feature myself.

Yes, empirically this is what happens, the VF probe detects that the
PF isn't ready yet, and returns error.
Few seconds later the VF is probed again and this time it works, today
we return -EIO, so we  need
to change that to  -EPROBE_DEFER to make that more robust.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/