Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758007Ab3EWKJ2 (ORCPT ); Thu, 23 May 2013 06:09:28 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:43605 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757845Ab3EWKJ1 (ORCPT ); Thu, 23 May 2013 06:09:27 -0400 Date: Thu, 23 May 2013 12:09:20 +0200 From: Thomas Petazzoni To: boris brezillon Cc: Jean-Christophe PLAGNIOL-VILLARD , Thomas Gleixner , Nicolas Ferre , Andrew Victor , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: at91: move at91 aic driver to drivers/irqchip Message-ID: <20130523120920.1df8e23a@skate> In-Reply-To: <519DE6A8.6040502@overkiz.com> References: <1369299909-10078-1-git-send-email-b.brezillon@overkiz.com> <1369299909-10078-2-git-send-email-b.brezillon@overkiz.com> <20130523090611.GG9937@game.jcrosoft.org> <519DE6A8.6040502@overkiz.com> Organization: Free Electrons X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1913 Lines: 51 Dear boris brezillon, On Thu, 23 May 2013 11:51:36 +0200, boris brezillon wrote: > On 23/05/2013 11:06, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 11:05 Thu 23 May , Boris BREZILLON wrote: > >> Move arch/arm/mach-at91/irq.c to drivers/irqchip/irq-at91.c. > >> Move arch/arm/mach-at91/at91_aic.h to > >> arch/arm/mach-at91/include/mach/at91_aic.h to avoid ugly reference > >> to header file : > >> #include "../../arch/arm/mach-at91/at91_aic.h" > > no we are going to drop arch/arm/mach-at91/include/mach for multi support > > > > arch/arm/mach-at91/include/mach is for removal > What should be done ? > > include ../../arch/arm/mach-at91/at91_aic.h from irq-at91.c > > or > > move at91_aic.h into drivers/irqchips and patch every non dt board to > include ../../../drivers/irqchip/at91_aic.h You can put it in , there are already a few headers there. But I think it's not the right solution. *However*, ideally, this header should disappear completely. All the register defines should go directly into the driver C file. The only usage of the AIC defines outside of the IRQ driver are for debug prints in the pm.c code, which I think you could get rid of. Ditto for the at91_aic_{read,write} macros. The NR_AIC5_IRQS can also move to the driver itself. The only remaining one would be NR_AIC_IRQS, you can't get rid of it, because it's used for the IRQ priority arrays. But I believe keeping this one in is reasonable. Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/