Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757890Ab3EWKgX (ORCPT ); Thu, 23 May 2013 06:36:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51162 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757799Ab3EWKgU (ORCPT ); Thu, 23 May 2013 06:36:20 -0400 Date: Thu, 23 May 2013 12:36:40 +0200 Message-ID: From: Takashi Iwai To: Ming Lei Cc: Dave Jones , "H. Peter Anvin" , Linux Kernel , x86@kernel.org, fenghua.yu@intel.com Subject: Re: microcode loading got really slow. In-Reply-To: References: <20130521230332.GC12713@redhat.com> <519D1668.6000601@zytor.com> <20130522200012.GA15456@redhat.com> <20130523033911.GA9411@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 31 At Thu, 23 May 2013 18:27:57 +0800, Ming Lei wrote: > > On Thu, May 23, 2013 at 6:16 PM, Takashi Iwai wrote: > > > > Thinking on this again, if the user-space continues to be broken in > > that point, we should provide request_firmware() variant without udev, > > e.g. request_firmware_direct(), and use it in known places like this? > > As anish said, it has been already there, No, f/w loader always fall back to user mode helper, as long as its support is built in. And doing that for microcode driver in that code path isn't only superfluous but also broken due to request_firmware call in module init. > wrt. this problem, I think we > need to know why the direct loading is failed. The reason is obvious: the requested f/w file doesn't exist. And it's fine, because the microcode update is an optional operation. If no f/w file is found, it's not handled as an error. It just means that no need to update, continuing to work. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/