Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759420Ab3EWPF0 (ORCPT ); Thu, 23 May 2013 11:05:26 -0400 Received: from 7of9.schinagl.nl ([88.159.158.68]:39510 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758002Ab3EWPFZ (ORCPT ); Thu, 23 May 2013 11:05:25 -0400 Message-ID: <519E3031.8080604@schinagl.nl> Date: Thu, 23 May 2013 17:05:21 +0200 From: Oliver Schinagl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130322 Thunderbird/17.0.4 MIME-Version: 1.0 To: Maxime Ripard CC: Linus Walleij , Arnd Bergmann , Greg KH , Oliver Schinagl , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses References: <1368797744-13737-1-git-send-email-oliver+list@schinagl.nl> <1368797744-13737-2-git-send-email-oliver+list@schinagl.nl> <519DCEE9.6070208@schinagl.nl> <20130523145835.GI8595@lukather> In-Reply-To: <20130523145835.GI8595@lukather> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 26 On 05/23/13 16:58, Maxime Ripard wrote: > On Thu, May 23, 2013 at 10:10:17AM +0200, Oliver Schinagl wrote: >> Then, i'm not sure if the driver is the best for this to be loaded? >> Maxime, what do you think? Personally I would feel more in having >> this in the mach-sunxi/core.c bit, but then again, this is currently >> a module and wouldn't be useful to have there. Maxime is far more >> knowledgeable to answer that. > > Hmmm, I don't understand what you mean here. Could you explain what you > have in mind? I've thought about it a little, and don't think core.c is a good spot, since the module will have to be loaded, or available there. And that's really early. So I guess, during probe, controlled by a parameter perhaps, load all 16 bytes into the random pool as Linus suggested? > > Thanks, > Maxime > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/