Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758710Ab3EWRYw (ORCPT ); Thu, 23 May 2013 13:24:52 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:64770 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757992Ab3EWRYt (ORCPT ); Thu, 23 May 2013 13:24:49 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 72.84.113.162 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/OzmqUeKjErjYPkLgDivroGOqQEa/iy7I= Date: Thu, 23 May 2013 13:23:39 -0400 From: Jason Cooper To: Jason Gunthorpe Cc: Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, David Miller , Lennert Buytenhek , Sebastian Hesselbarth Subject: Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs Message-ID: <20130523172339.GQ31290@titan.lakedaemon.net> References: <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369253042-15082-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369253042-15082-2-git-send-email-sebastian.hesselbarth@gmail.com> <20130522201607.GA18823@obsidianresearch.com> <20130523160111.GP31290@titan.lakedaemon.net> <20130523171112.GB31281@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130523171112.GB31281@obsidianresearch.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1794 Lines: 43 On Thu, May 23, 2013 at 11:11:12AM -0600, Jason Gunthorpe wrote: > On Thu, May 23, 2013 at 12:01:11PM -0400, Jason Cooper wrote: > > > > + /* Kirkwood resets some registers on gated clocks. Especially > > > > + * CLK125_BYPASS_EN must be cleared but is not available on > > > > + * all other SoCs/System Controllers using this driver. > > > > + */ > > > > + if (of_machine_is_compatible("marvell,kirkwood")) > > > > + wrlp(mp, PORT_SERIAL_CONTROL1, > > > > + rdlp(mp, PORT_SERIAL_CONTROL1) & ~CLK125_BYPASS_EN); > > > > > > of_machine_is_compatible seems heavy handed, I would expect this to be > > > based on the compatible string of the ethernet node itself, not the > > > machine?? > > > > Is there a model number variation between IP that needs this and IP that > > doesn't? If not, I'm fine with of_machine_is_compatible(). > > Well the name 'mv643xx' is a family of system controller SOC's > from ages ago, it seems reasonble to continue the trend and label the > IP variations with the SOC name: > > compatible = "marvell,kirwood,ethernet", "marvell,mv643xx_eth" Shouldn't it rather be compatible = "marvell,kirkwood-eth", "marvell,orion-eth"; I'm inclined to go with of_machine_is_compatible() since the only concrete difference we know is that the tweak is needed on kirkwood and nowhere else. If we had an errata, or a datasheet saying specifically flavor X needs this and none other does, then we could trigger on the ethernet node compatible string or a boolean in the node. But we don't have that... thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/