Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759909Ab3EWWrB (ORCPT ); Thu, 23 May 2013 18:47:01 -0400 Received: from terminus.zytor.com ([198.137.202.10]:58303 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759888Ab3EWWq7 (ORCPT ); Thu, 23 May 2013 18:46:59 -0400 Message-ID: <519E9C4C.3080305@zytor.com> Date: Thu, 23 May 2013 15:46:36 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Matt Fleming CC: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Matt Fleming , Matthew Garrett , Seth Forshee , Jesse Barnes , stable@vger.kernel.org Subject: Re: [PATCH] x86/PCI: setup data may be in highmem References: <1369215782-32697-1-git-send-email-matt@console-pimps.org> In-Reply-To: <1369215782-32697-1-git-send-email-matt@console-pimps.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 21 On 05/22/2013 02:43 AM, Matt Fleming wrote: > From: Matt Fleming > > pcibios_add_device() assumes that the physical addresses stored in > setup_data are accessible via the direct kernel mapping, and that > calling phys_to_virt() is valid. This isn't guaranteed to be true on x86 > where the direct mapping range is much smaller than on x86-64. > > Calling phys_to_virt() on a highmem address results in the following, > Bjorn: yours or mine? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/