Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760353Ab3EXKOY (ORCPT ); Fri, 24 May 2013 06:14:24 -0400 Received: from mail.free-electrons.com ([94.23.35.102]:42457 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760156Ab3EXKOW (ORCPT ); Fri, 24 May 2013 06:14:22 -0400 Date: Fri, 24 May 2013 12:14:19 +0200 From: Maxime Ripard To: Florian Fainelli Cc: David Miller , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Roese , Emilio Lopez , kevin@allwinnertech.com, sunny@allwinnertech.com, shuge@allwinnertech.com Subject: Re: [PATCHv3 2/6] net: Add MDIO bus driver for the Allwinner EMAC Message-ID: <20130524101419.GC8785@lukather> References: <1369387394-9453-1-git-send-email-maxime.ripard@free-electrons.com> <1369387394-9453-3-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 41 Hi Florian, On Fri, May 24, 2013 at 10:42:30AM +0100, Florian Fainelli wrote: > Hello Maxime, > > 2013/5/24 Maxime Ripard > > > > This patch adds a separate driver for the MDIO interface of the > > Allwinner ethernet controllers. > > > > Signed-off-by: Maxime Ripard > > --- > > .../bindings/net/allwinner,sun4i-mdio.txt | 26 +++ > > drivers/net/ethernet/allwinner/Kconfig | 8 + > > drivers/net/ethernet/allwinner/Makefile | 1 + > > drivers/net/ethernet/allwinner/sun4i-mdio.c | 191 +++++++++++++++++++++ > > Ok, so you probably followed Thomas's example here with mvneta/mvmdio, > but all other MDIO bus drivers live in drivers/net/phy. Indeed I shamelessly followed Thomas here. > Unfortunately, mvmdio lives in drivers/net/ethernet/marvell/mvmdio.c > which I should have noticed before. Whatever is good for you guys, but > we should probably start normalizing this now before more mdio drivers > get merged alongside their corresponding ethernet MAC users. I'm fine with either way, just tell me where to put it and I'll happily do so. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/