Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751075Ab3EZEEu (ORCPT ); Sun, 26 May 2013 00:04:50 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:43361 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714Ab3EZEEr (ORCPT ); Sun, 26 May 2013 00:04:47 -0400 Date: Sat, 25 May 2013 21:04:41 -0700 (PDT) Message-Id: <20130525.210441.818472895703230779.davem@davemloft.net> To: sebastian.hesselbarth@gmail.com Cc: buytenh@wantstofly.org, jason@lakedaemon.net, andrew@lunn.ch, benh@kernel.crashing.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: kirkwood: proper retain MAC address workaround on DT ethernet From: David Miller In-Reply-To: <1369253042-15082-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369253042-15082-1-git-send-email-sebastian.hesselbarth@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 16 From: Sebastian Hesselbarth Date: Wed, 22 May 2013 22:04:01 +0200 > + memcpy((void *)p->value, reg, 6); This cast is completely unnecessary, non-void to void pointer casts are automatic. If it is necessary, because p->value is const, then you are trying to change something behind the OF layer's back and need to use the appropriate interface to change the property contents. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/