Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751554Ab3EZI7o (ORCPT ); Sun, 26 May 2013 04:59:44 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:59004 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139Ab3EZI7m (ORCPT ); Sun, 26 May 2013 04:59:42 -0400 Date: Sun, 26 May 2013 10:59:38 +0200 From: Michal Hocko To: Wanpeng Li Cc: Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , David Rientjes , Jiang Liu , Tang Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH v3 2/6] mm/memory_hotplug: remove memory_add_physaddr_to_nid Message-ID: <20130526085938.GD10651@dhcp22.suse.cz> References: <1369547921-24264-1-git-send-email-liwanp@linux.vnet.ibm.com> <1369547921-24264-2-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369547921-24264-2-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1696 Lines: 51 On Sun 26-05-13 13:58:37, Wanpeng Li wrote: > memory_add_physaddr_to_nid is not used any more, this patch remove it. git grep disagrees. git grep "= *\" mmotm mmotm:drivers/acpi/acpi_memhotplug.c: node = memory_add_physaddr_to_nid(info->start_addr); mmotm:drivers/acpi/acpi_memhotplug.c: nid = memory_add_physaddr_to_nid(info->start_addr); mmotm:drivers/base/memory.c: nid = memory_add_physaddr_to_nid(phys_addr); mmotm:drivers/xen/balloon.c: nid = memory_add_physaddr_to_nid(hotplug_start_paddr); > > Signed-off-by: Wanpeng Li > --- > arch/x86/mm/numa.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index a71c4e2..d470a54 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -803,18 +803,3 @@ const struct cpumask *cpumask_of_node(int node) > EXPORT_SYMBOL(cpumask_of_node); > > #endif /* !CONFIG_DEBUG_PER_CPU_MAPS */ > - > -#ifdef CONFIG_MEMORY_HOTPLUG > -int memory_add_physaddr_to_nid(u64 start) > -{ > - struct numa_meminfo *mi = &numa_meminfo; > - int nid = mi->blk[0].nid; > - int i; > - > - for (i = 0; i < mi->nr_blks; i++) > - if (mi->blk[i].start <= start && mi->blk[i].end > start) > - nid = mi->blk[i].nid; > - return nid; > -} > -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > -#endif > -- > 1.8.1.2 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/