Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752589Ab3EZL7F (ORCPT ); Sun, 26 May 2013 07:59:05 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:47134 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488Ab3EZL7D (ORCPT ); Sun, 26 May 2013 07:59:03 -0400 MIME-Version: 1.0 In-Reply-To: <20130526090054.GE10651@dhcp22.suse.cz> References: <1369547921-24264-1-git-send-email-liwanp@linux.vnet.ibm.com> <1369547921-24264-3-git-send-email-liwanp@linux.vnet.ibm.com> <20130526090054.GE10651@dhcp22.suse.cz> From: KOSAKI Motohiro Date: Sun, 26 May 2013 07:58:42 -0400 Message-ID: Subject: Re: [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit To: Michal Hocko Cc: Wanpeng Li , Andrew Morton , KAMEZAWA Hiroyuki , David Rientjes , Jiang Liu , Tang Chen , "linux-mm@kvack.org" , LKML , Greg Kroah-Hartman , stable@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 873 Lines: 24 >> As KOSAKI Motohiro mentioned, memory hotplug don't support 32bit since >> it was born, > > Why? any reference? This reasoning is really weak. I have no seen any highmem support in memory hotplug code and I don't think this patch fixes all 32bit highmem issue. If anybody are interesting to support it, it is good thing. But in fact, _now_ it is broken when enable HIGHMEM. So, I just want to mark broken until someone want to support highmem and verify overall. And, yes, this patch is no good. Kconfig doesn't describe why disable when highmem. So, depends on 64BIT || !HIGHMEM || BROKEN maybe clear documentation more. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/