Date: Sun, 26 May 2013 16:34:03 +0200
From: Wim Van Sebroeck <wim@iguana.be>
To: johannes.thumshirn@men.de
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: New watchdog driver for MEN A21 watchdogs
Message-ID: <20130526143403.GB7603@spo001.leaseweb.com>
References: <1368560034.24692.4.camel@joe-AO722> <1368643810-2789-1-git-send-email-johannes.thumshirn@men.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1368643810-2789-1-git-send-email-johannes.thumshirn@men.de>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1272
Lines: 43

Hi Johannes,

> +static int a21_wdt_notify_sys(struct notifier_block *notify, unsigned long code,
> +			void *unused)
> +{
> +	if (code == SYS_DOWN || code == SYS_HALT)
> +		gpio_set_value(GPIO_WD_ENAB, 0);
> +
> +	return NOTIFY_DONE;
> +}
> +
> +static struct notifier_block a21_wdt_notifier = {
> +	.notifier_call = a21_wdt_notify_sys,
> +};
...
> +	ret = register_reboot_notifier(&a21_wdt_notifier);
> +	if (ret) {
> +		dev_err(&pdev->dev, "Cannot register reboot notifier\n");
> +		goto err_register_notif;
> +	unregister_reboot_notifier(&a21_wdt_notifier);
...
> +	unregister_reboot_notifier(&a21_wdt_notifier);
...
> +static struct platform_driver a21_wdt_driver = {
> +	.probe = a21_wdt_probe,
> +	.remove = a21_wdt_remove,
> +	.driver = {
> +		.name = "a21-watchdog",
> +		.of_match_table = a21_wdt_ids,
> +	},
> +};

I prefer to have the reboot_notifier is being replaced by a platform .shutdown function.
Can you also split the sysfs stuff as a second patch so that I can review that seperately?

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/