Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753739Ab3EZOhH (ORCPT ); Sun, 26 May 2013 10:37:07 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:44235 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217Ab3EZOhF (ORCPT ); Sun, 26 May 2013 10:37:05 -0400 Message-ID: <51A21E0D.2030509@cogentembedded.com> Date: Sun, 26 May 2013 18:37:01 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Prabhakar Lad CC: Hans Verkuil , Mauro Carvalho Chehab , LMML , Laurent Pinchart , DLOS , LKML Subject: Re: [PATCH v3 2/9] media: davinci: vpif: Convert to devm_* api References: <1369569612-30915-1-git-send-email-prabhakar.csengg@gmail.com> <1369569612-30915-3-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1369569612-30915-3-git-send-email-prabhakar.csengg@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1640 Lines: 49 Hello. On 26-05-2013 16:00, Prabhakar Lad wrote: > From: Lad, Prabhakar > Use devm_ioremap_resource instead of reques_mem_region()/ioremap(). > This ensures more consistent error values and simplifies error paths. > Signed-off-by: Lad, Prabhakar > Acked-by: Laurent Pinchart > --- > drivers/media/platform/davinci/vpif.c | 27 ++++----------------------- > 1 files changed, 4 insertions(+), 23 deletions(-) > diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c > index 761c825..f857d8f 100644 > --- a/drivers/media/platform/davinci/vpif.c > +++ b/drivers/media/platform/davinci/vpif.c [...] > @@ -421,23 +419,12 @@ EXPORT_SYMBOL(vpif_channel_getfid); > > static int vpif_probe(struct platform_device *pdev) > { > - int status = 0; > + static struct resource *res; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); [...] > + vpif_base = devm_request_and_ioremap(&pdev->dev, res); No, don't use this deprecated funtion please. Undo to devm_ioremap_resource(). > + if (IS_ERR(vpif_base)) NAK, devm_request_and_ioremap() doesn't rethrn error cpdes, only NULL. BTW, it's implemented via a call to devm_ioremap_resource() now. Is it so hard to look at the code that you've calling? > + return PTR_ERR(vpif_base); WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/