Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754804Ab3EZSJj (ORCPT ); Sun, 26 May 2013 14:09:39 -0400 Received: from mail-we0-f170.google.com ([74.125.82.170]:33768 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754737Ab3EZSJi (ORCPT ); Sun, 26 May 2013 14:09:38 -0400 Date: Sun, 26 May 2013 20:09:33 +0200 From: Michal Hocko To: KOSAKI Motohiro Cc: Wanpeng Li , Andrew Morton , KAMEZAWA Hiroyuki , David Rientjes , Jiang Liu , Tang Chen , "linux-mm@kvack.org" , LKML , Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [patch v2 3/6] mm/memory_hotplug: Disable memory hotremove for 32bit Message-ID: <20130526180933.GA20270@dhcp22.suse.cz> References: <1369547921-24264-1-git-send-email-liwanp@linux.vnet.ibm.com> <1369547921-24264-3-git-send-email-liwanp@linux.vnet.ibm.com> <20130526090054.GE10651@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 32 On Sun 26-05-13 07:58:42, KOSAKI Motohiro wrote: > >> As KOSAKI Motohiro mentioned, memory hotplug don't support 32bit since > >> it was born, > > > > Why? any reference? This reasoning is really weak. > > I have no seen any highmem support in memory hotplug code and I don't think this > patch fixes all 32bit highmem issue. If anybody are interesting to > support it, it is good thing. But in fact, _now_ it is broken when > enable HIGHMEM. > So, I just want to mark broken until someone want to support highmem > and verify overall. > > And, yes, this patch is no good. Kconfig doesn't describe why disable > when highmem. > So, > > depends on 64BIT || !HIGHMEM || BROKEN > > maybe clear documentation more. I have no objection to disbale the feature for HIGHMEM configurations I was merely complaining that the patch didn't describe _why_. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/