Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757229Ab3E0Ifm (ORCPT ); Mon, 27 May 2013 04:35:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48494 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757117Ab3E0Ifl (ORCPT ); Mon, 27 May 2013 04:35:41 -0400 Date: Mon, 27 May 2013 10:35:57 +0200 Message-ID: From: Takashi Iwai To: Daniel Mack Cc: linux-kernel@vger.kernel.org, ming.lei@canonical.com, gregkh@linuxfoundation.org, tiwai@suse.de Subject: Re: [PATCH] firmware: move EXPORT_SYMBOL annotations In-Reply-To: <1369340238-8631-1-git-send-email-zonque@gmail.com> References: <1369340238-8631-1-git-send-email-zonque@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2305 Lines: 81 At Thu, 23 May 2013 22:17:18 +0200, Daniel Mack wrote: > > Move EXPORT_SYMBOL annotations so they follow immediately after the > closing function brace line. > > Signed-off-by: Daniel Mack Acked-by: Takashi Iwai thanks, Takashi > --- > drivers/base/firmware_class.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c > index 4b1f926..4d9643f 100644 > --- a/drivers/base/firmware_class.c > +++ b/drivers/base/firmware_class.c > @@ -1079,6 +1079,7 @@ request_firmware(const struct firmware **firmware_p, const char *name, > { > return _request_firmware(firmware_p, name, device, true, false); > } > +EXPORT_SYMBOL(request_firmware); > > /** > * release_firmware: - release the resource associated with a firmware image > @@ -1092,6 +1093,7 @@ void release_firmware(const struct firmware *fw) > kfree(fw); > } > } > +EXPORT_SYMBOL(release_firmware); > > /* Async support */ > struct firmware_work { > @@ -1172,6 +1174,7 @@ request_firmware_nowait( > schedule_work(&fw_work->work); > return 0; > } > +EXPORT_SYMBOL(request_firmware_nowait); > > /** > * cache_firmware - cache one firmware image in kernel memory space > @@ -1202,6 +1205,7 @@ int cache_firmware(const char *fw_name) > > return ret; > } > +EXPORT_SYMBOL_GPL(cache_firmware); > > /** > * uncache_firmware - remove one cached firmware image > @@ -1232,6 +1236,7 @@ int uncache_firmware(const char *fw_name) > > return -EINVAL; > } > +EXPORT_SYMBOL_GPL(uncache_firmware); > > #ifdef CONFIG_PM_SLEEP > static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain); > @@ -1536,9 +1541,3 @@ static void __exit firmware_class_exit(void) > > fs_initcall(firmware_class_init); > module_exit(firmware_class_exit); > - > -EXPORT_SYMBOL(release_firmware); > -EXPORT_SYMBOL(request_firmware); > -EXPORT_SYMBOL(request_firmware_nowait); > -EXPORT_SYMBOL_GPL(cache_firmware); > -EXPORT_SYMBOL_GPL(uncache_firmware); > -- > 1.8.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/