Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757589Ab3E0KxQ (ORCPT ); Mon, 27 May 2013 06:53:16 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:43458 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436Ab3E0KxP (ORCPT ); Mon, 27 May 2013 06:53:15 -0400 MIME-Version: 1.0 In-Reply-To: <1369480087-24786-5-git-send-email-dt.tangr@gmail.com> References: <1369480087-24786-1-git-send-email-dt.tangr@gmail.com> <1369480087-24786-5-git-send-email-dt.tangr@gmail.com> Date: Mon, 27 May 2013 12:53:14 +0200 Message-ID: Subject: Re: [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support From: Linus Walleij To: Daniel Tang Cc: "linux-arm-kernel@lists.infradead.org" , "linux@arm.linux.org.uk ARM Linux" , Arnd Bergmann , "fabian@ritter-vogt.de Vogt" , Lionel Debroux , "linux-kernel@vger.kernel.org" , John Stultz , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1977 Lines: 57 On Sat, May 25, 2013 at 1:08 PM, Daniel Tang wrote: > Add clocksource and clockevent driver for the TI-Nspire. > > Signed-off-by: Daniel Tang This is *much* improved :-D But: > +++ b/drivers/clocksource/zevio-timer.c > +static void zevio_timer_set_mode(enum clock_event_mode mode, > + struct clock_event_device *dev) > +{ > + unsigned long flags; > + struct zevio_timer *timer = container_of(dev, > + struct zevio_timer, > + clkevt); > + > + local_irq_save(flags); > + > + switch (mode) { > + case CLOCK_EVT_MODE_PERIODIC: > + /* Unsupported */ > + break; > + case CLOCK_EVT_MODE_RESUME: > + case CLOCK_EVT_MODE_ONESHOT: > + /* Enable timer interrupts */ > + writel(TIMER_INTR_MSK, timer->interrupt_regs + IO_INTR_MSK); > + writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK); > + dev->mode = mode; > + break; > + case CLOCK_EVT_MODE_SHUTDOWN: > + case CLOCK_EVT_MODE_UNUSED: > + /* Disable timer interrupts */ > + writel(0, timer->interrupt_regs + IO_INTR_MSK); > + writel(TIMER_INTR_ALL, timer->interrupt_regs + IO_INTR_ACK); > + /* Stop timer */ > + writel(CNTL_STOP_TIMER, timer->timer1 + IO_CONTROL); > + dev->mode = mode; > + break; > + } Surely both the compiler and checkpatch is complaining that this switch does not contain a default: clause? If you fix this you can add my: Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/