From: Arnd Bergmann <arnd@arndb.de>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Subject: Re: [PATCH 02/14] misc/ep93xx_pwm: use {read,write}* instead of __raw_* versions for io
Date: Mon, 27 May 2013 17:18:41 +0200
User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; )
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, gregkh@linuxfoundation.org,
        Ryan Mallon <rmallon@gmail.com>, mcrapet@gmail.com,
        hsweeten@visionengravers.com
References: <201305241621.50447.hartleys@visionengravers.com>
In-Reply-To: <201305241621.50447.hartleys@visionengravers.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201305271718.41851.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 769
Lines: 19

On Saturday 25 May 2013, H Hartley Sweeten wrote:
> @@ -42,13 +42,13 @@ struct ep93xx_pwm {
>  static inline void ep93xx_pwm_writel(struct ep93xx_pwm *pwm,
>                 unsigned int val, unsigned int off)
>  {
> -       __raw_writel(val, pwm->mmio_base + off);
> +       writel(val, pwm->mmio_base + off);
>  }

Just an idea: since you are adding the writel in a lot of places in subsequent
patches, you could rename 'mmio_base' to the shorter 'base' first, which would
make the resulting code actually smaller.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/