Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755803Ab3E0RRk (ORCPT ); Mon, 27 May 2013 13:17:40 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:48029 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915Ab3E0RRj (ORCPT ); Mon, 27 May 2013 13:17:39 -0400 Message-ID: <51A3952C.3060006@cogentembedded.com> Date: Mon, 27 May 2013 21:17:32 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Aaro Koskinen CC: Ralf Baechle , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once References: <1369600543-21558-1-git-send-email-aaro.koskinen@iki.fi> <51A33317.2060202@cogentembedded.com> In-Reply-To: <51A33317.2060202@cogentembedded.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1500 Lines: 39 On 27-05-2013 14:19, Sergei Shtylyov wrote: >> When booting a new board for the first time, the console is flooded with >> "Unknown board" messages. This is not really helpful. Board type is not >> going to change after the boot, so it's sufficient to print the warning >> only once. >> Signed-off-by: Aaro Koskinen >> --- >> arch/mips/cavium-octeon/executive/cvmx-helper-board.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c >> b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c >> index 7c64977..e0451a0 100644 >> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c >> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c > [...] >> @@ -184,8 +186,7 @@ int cvmx_helper_board_get_mii_address(int ipd_port) >> } >> >> /* Some unknown board. Somebody forgot to update this >> function... */ >> - cvmx_dprintf >> - ("cvmx_helper_board_get_mii_address: Unknown board type %d\n", >> + pr_warn_once("%s: Unknown board type %d\n", __func__, >> cvmx_sysinfo_get()->board_type); > Please align this line under the next char under (. s/under (/after (/, of course. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/