Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758687Ab3E1CcB (ORCPT ); Mon, 27 May 2013 22:32:01 -0400 Received: from mga14.intel.com ([143.182.124.37]:1992 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758658Ab3E1Cbq (ORCPT ); Mon, 27 May 2013 22:31:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,755,1363158000"; d="scan'208";a="247435724" From: Lan Tianyu To: lenb@kernel.org, rjw@sisk.pl, linux-kernel@vger.kernel.org, mjg59@srcf.ucam.org, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, mytbk920423@gmail.com Cc: Lan Tianyu , stable@vger.kernel.org Subject: [PATCH] Platform/HP: Fix misuse variable bluetooth_rfkill in the hp_wmi_rfkill_setup() Date: Tue, 28 May 2013 10:25:33 +0800 Message-Id: <1369707933-8565-1-git-send-email-tianyu.lan@intel.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2898 Lines: 61 HP wmi platform driver fails to initialize GPS and causes poweroff failure in HP Elitebook 6930p. [ 9.462428] Call Trace: [ 9.462449] [] hp_wmi_bios_setup+0x25a/0x3a0 [hp_wmi] [ 9.462493] [] platform_drv_probe+0x3c/0x70 [ 9.462530] [] ? driver_sysfs_add+0x7a/0xb0 [ 9.462566] [] driver_probe_device+0x87/0x3a0 [ 9.462603] [] __driver_attach+0x93/0xa0 [ 9.462636] [] ? __device_attach+0x40/0x40 [ 9.462671] [] bus_for_each_dev+0x63/0xa0 [ 9.462707] [] driver_attach+0x1e/0x20 [ 9.462740] [] bus_add_driver+0x1f8/0x2b0 [ 9.462775] [] driver_register+0x71/0x150 [ 9.462810] [] platform_driver_register+0x46/0x50 [ 9.462849] [] platform_driver_probe+0x1b/0xa0 [ 9.462886] [] hp_wmi_init+0x1be/0x1fb [hp_wmi] [ 9.462925] [] ? hp_wmi_bios_setup+0x3a0/0x3a0 [hp_wmi] [ 9.462967] [] do_one_initcall+0x10a/0x160 [ 9.463004] [] load_module+0x1b46/0x2640 [ 9.463038] [] ? ddebug_proc_write+0xf0/0xf0 [ 9.463076] [] sys_init_module+0xa2/0xf0 [ 9.463111] [] system_call_fastpath+0x1a/0x1f [ 9.463146] Code: 48 ff ff ff 80 7b 24 00 74 d2 41 83 e5 01 45 38 ec 74 c9 48 8d bb a0 03 00 00 e8 ed fb aa e0 5b 41 5c 41 5d 44 89 f0 41 5e 5d c3 <0f> 0b 66 66 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 [ 9.463479] RIP [] rfkill_set_hw_state+0x9f/0xb0 [rfkill] [ 9.463526] RSP Check code and find this error is caused by misusing variable bluetooth_rfkill where gps_rfkill should be. Reported-and-tested-by: Iru Cai References: https://bugzilla.kernel.org/show_bug.cgi?id=58401 Cc: stable@vger.kernel.org Signed-off-by: Lan Tianyu --- drivers/platform/x86/hp-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index 45cacf7..9b60282 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -680,7 +680,7 @@ static int hp_wmi_rfkill_setup(struct platform_device *device) } rfkill_init_sw_state(gps_rfkill, hp_wmi_get_sw_state(HPWMI_GPS)); - rfkill_set_hw_state(bluetooth_rfkill, + rfkill_set_hw_state(gps_rfkill, hp_wmi_get_hw_state(HPWMI_GPS)); err = rfkill_register(gps_rfkill); if (err) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/