Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998Ab3E1GIK (ORCPT ); Tue, 28 May 2013 02:08:10 -0400 Received: from intranet.asianux.com ([58.214.24.6]:1355 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932969Ab3E1GIJ (ORCPT ); Tue, 28 May 2013 02:08:09 -0400 X-Spam-Score: -100.8 Message-ID: <51A44990.5010109@asianux.com> Date: Tue, 28 May 2013 14:07:12 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Anton Vorontsov CC: jason.wessel@windriver.com, sasha.levin@oracle.com, vincent.stehle@laposte.net, john.blackwood@ccur.com, kgdb-bugreport@lists.sourceforge.net, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas. References: <5194C23A.3090405@asianux.com> <20130523172849.GB30160@teo> <519EBFD2.60105@asianux.com> In-Reply-To: <519EBFD2.60105@asianux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1738 Lines: 50 On 05/24/2013 09:18 AM, Chen Gang wrote: > On 05/24/2013 01:28 AM, Anton Vorontsov wrote: >> > On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote: >>>> >> > Delete waste '{' for 'case' statement. >>>> >> > >>>> >> > For the return variable 'long res' in function kdb_task_state_string(), >>>> >> > neither it matches the function return type 'unsigned long', nor is >>>> >> > suitable as a flag variable to make 'or' operation. So use 'unsigned >>>> >> > long' instead of 'long'. >>>> >> > >>>> >> > If "case 'A'" happen in function kdb_task_state_string(), can return >>>> >> > ~0UL directly to save the useless looping. >>>> >> > >>>> >> > Signed-off-by: Chen Gang >> > If anything, these should be 3 separate patches... >> > My original 3 fix issues old patches for "kernel/debug" are still non-reply, then the new minor cleanup patches (if I will provide the 3 patches) will of cause be none-reply, too. Now, I am not a newbie anymore, so I can/should understand it, at least, it should not stop me to continue providing patches to another members. And thank you for your encouraging. :-) > OK, I will separate them into 3 patches (originally, I think for trivial > cleanup patches, better let them in one patch, so can save the reviewers > and appliers time) > > Excuse me, I have to do something else, so I will finish them within > this month (2013-05-31) > > > Thanks. > -- Chen Gang Asianux Corporation -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/