Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757544Ab3E1KU1 (ORCPT ); Tue, 28 May 2013 06:20:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34336 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756192Ab3E1KU0 (ORCPT ); Tue, 28 May 2013 06:20:26 -0400 Date: Tue, 28 May 2013 12:20:25 +0200 (CEST) From: Jiri Kosina To: Christian Ohm Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] HID: Add driver for Holtek gaming mouse 04d9:a067 In-Reply-To: <39428ed7f69bd06e3d93f730ba8f7b7b0a3f6c26.1369083628.git.chr.ohm@gmx.net> Message-ID: References: <39428ed7f69bd06e3d93f730ba8f7b7b0a3f6c26.1369083628.git.chr.ohm@gmx.net> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 28 On Tue, 21 May 2013, Christian Ohm wrote: > This mouse is sold as Sharkoon Drakonia and Perixx MX-2000 and reports a > too high usage maximum and logical maximum. This driver fixes the report > descriptor so those values don't exceed HID_MAX_USAGES. > > Signed-off-by: Christian Ohm > --- > drivers/hid/Kconfig | 1 + > drivers/hid/Makefile | 1 + > drivers/hid/hid-holtek-mouse.c | 72 ++++++++++++++++++++++++++++++++++++++++ > drivers/hid/hid-ids.h | 1 + > 4 files changed, 75 insertions(+) > create mode 100644 drivers/hid/hid-holtek-mouse.c You also need an entry in hid_have_special_driver[] for the devices in order for the device <-> driver binding work properly. I have applied your patches and fixed that omission. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/